feat(terraform-vault): let the kubeconfig path be given instead of derived - #177
Merged
Merged
Conversation
…rived
cluster-name has been doing two jobs: naming the cluster to terraform, and
locating its kubeconfig via
KUBE_CONFIG_ENC: secrets/kubeconfigs/${{ inputs.cluster-name }}.yaml
Those disagree in practice, because kubeconfigs are named inconsistently --
philly.yaml and cicd-crossplane.yaml carry no lab, labda-cicd-machinery-test5
and labda-sthings-infra do. A caller whose file is prefixed had to pass the
prefixed name, and then got that prefix into every Vault object the terraform
config names.
Concretely: cicd-machinery-test5 already has an ESO mount
`cicd-machinery-test5` and a k8s-auth mount `cicd-machinery-test5-eso`, but its
kubeconfig is labda-cicd-machinery-test5.yaml. No value of cluster-name
produced both.
kubeconfig-file defaults to empty and derives the old path, so nothing existing
changes. Same guard shape as #175 and for the same reason: workflow_dispatch
does not define the input, so a dispatched run reads it as empty and must fall
back.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K2rfvVDXWjWZAKMcpwvgLG
patrick-hermann-sva
force-pushed
the
feat/terraform-vault-kubeconfig-input
branch
from
September 9, 2026 12:30
d8366f2 to
f4b5751
Compare
patrick-hermann-sva
deleted the
feat/terraform-vault-kubeconfig-input
branch
September 9, 2026 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cluster-namehas been doing two jobs: naming the cluster to terraform, and locating its kubeconfig.Those two disagree in practice, because kubeconfigs are named inconsistently:
A caller whose file is prefixed had to pass the prefixed name — and then got that prefix into every Vault object the terraform config names. Concretely:
cicd-machinery-test5already has an ESO mountcicd-machinery-test5and a k8s-auth mountcicd-machinery-test5-eso, but its kubeconfig islabda-cicd-machinery-test5.yaml. There was no value ofcluster-namethat produced both.kubeconfig-filedefaults to empty and derives the old path, so nothing existing changes. Same guard shape as #175, for the same reason:workflow_dispatchdoes not define the input, so a dispatched run reads it as empty and must fall back.🤖 Generated with Claude Code
https://claude.ai/code/session_01K2rfvVDXWjWZAKMcpwvgLG