feat(push-kustomize): render from a caller-chosen ref - #173
Merged
Conversation
On a pull request actions/checkout takes the merge commit GitHub builds, not the head. A caller whose tag is composed from head_sha therefore publishes an artefact rendered from a different commit than the one its name points at, and nothing about that is visible without comparing by hand. schmetterpause has shipped exactly that twice (its #177 and #179) and carries `ref: github.event.pull_request.head.sha` in its own inline job because of it. It is the last reason that job cannot become a call to this workflow. Empty by default, so push and workflow_dispatch keep checkout's own default and no existing caller changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146MzPecusrKBGXKenKsKY1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a
pull_request,actions/checkouttakes the merge commit GitHub builds, not the head. A caller whose tag is composed fromhead_shatherefore publishes an artefact rendered from a different commit than the one its name points at — and nothing about that is visible without comparing by hand.schmetterpausehas shipped exactly that twice (its #177 and #179) and its inline job carries the fix in a comment that says so:That is the last reason its ~120-line inline job cannot simply call this workflow. With #169 (
kcl-parameters), #170 (additional-tags) and this one, it can — and the follow-up in schmetterpause deletes it.It matters here for a second reason the comment also names: the source rendered is
kcl/, and the profile under it may be exactly what the pull request changes. Rendering the merge commit would then publish an artefact of something the author did not write.Backward compatible
Empty by default, so
pushandworkflow_dispatchkeep checkout's own default and no existing caller changes behaviour.🤖 Generated with Claude Code
https://claude.ai/code/session_0146MzPecusrKBGXKenKsKY1