Skip to content

Make ScrollViewer::ScrollOfInternal private - #3361

Open
ds5678 wants to merge 1 commit into
stride3d:masterfrom
ds5678:private-scroll-of-internal
Open

Make ScrollViewer::ScrollOfInternal private#3361
ds5678 wants to merge 1 commit into
stride3d:masterfrom
ds5678:private-scroll-of-internal

Conversation

@ds5678

@ds5678 ds5678 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

PR Details

I noticed this method was public while working on some UI stuff and figured that it was never intended to be used outside this class.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR

Copy link
Copy Markdown
Member

Agreed on the principle. However making a method private is technically a breaking changes. Unlikely anyone was using it, but who knows?

@ds5678

ds5678 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Agreed on the principle. However making a method private is technically a breaking changes. Unlikely anyone was using it, but who knows?

Does Stride have an official policy on breaking changes and when they're justified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants