Make ScrollViewer::ScrollOfInternal private - #3361
Open
ds5678 wants to merge 1 commit into
Open
Conversation
Member
|
Agreed on the principle. However making a method private is technically a breaking changes. Unlikely anyone was using it, but who knows? |
Contributor
Author
Does Stride have an official policy on breaking changes and when they're justified? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
I noticed this method was public while working on some UI stuff and figured that it was never intended to be used outside this class.
Related Issue
Types of changes
Checklist