[Video] Drops dependency to SharpDX.MediaFoundation using Microsoft.Windows.CsWin32 #3032
+322
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indows.CsWin32 Once the MF bindings are part of Silk.NET it should be easy to replace. Note that Microsoft.Windows.CsWin32 is a compile time dependency only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
By using Microsoft.Windows.CsWin32 we can drop the dependency to SharpDX.MediaFoundation.
Once the MF bindings are part of Silk.NET it should be easy to replace.
Note that Microsoft.Windows.CsWin32 is a compile time dependency only.
Related Issue
dotnet/Silk.NET#2466
Types of changes
Checklist
I did create a little game playing two videos - was working fine. Also shutdown didn't crash.