feat(sinks): align sinks tools configurations, add e2e tests#78
Merged
feat(sinks): align sinks tools configurations, add e2e tests#78
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the Pulsar sinks tool to align configurations with the functions tool and adds end-to-end tests. The changes make tenant and namespace optional (defaulting to "public" and "default"), expand the tool's parameter set to support more sink configuration options, and introduce a new buildSinkConfig method that replaces the previous processArguments approach.
Changes:
- Refactored sink configuration building with a new
buildSinkConfigmethod that supports loading configuration from YAML files - Changed tenant and namespace from required to optional parameters with default values
- Added support for 20+ new sink configuration parameters (cpu, ram, disk, custom-serde-inputs, secrets, etc.)
- Added comprehensive e2e tests for create, update, get, and delete operations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| pkg/mcp/builders/pulsar/sinks_parity_test.go | New unit tests for sink configuration building, defaults, and validation |
| pkg/mcp/builders/pulsar/sinks.go | Major refactoring of sink configuration logic with new parameters and improved validation |
| docs/tools/pulsar_admin_sinks.md | Updated documentation to reflect optional tenant/namespace and new parameters |
| cmd/snmcp-e2e/main.go | Added e2e test workflow for sink lifecycle (create, update, get, delete) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ce config handling
jiangpengcheng
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.