Skip to content

feat(sinks): align sinks tools configurations, add e2e tests#78

Merged
freeznet merged 7 commits intomainfrom
freeznet/align-pulsar-admin-sinks
Feb 5, 2026
Merged

feat(sinks): align sinks tools configurations, add e2e tests#78
freeznet merged 7 commits intomainfrom
freeznet/align-pulsar-admin-sinks

Conversation

@freeznet
Copy link
Member

@freeznet freeznet commented Feb 4, 2026

No description provided.

@freeznet freeznet self-assigned this Feb 4, 2026
@freeznet freeznet requested a review from a team as a code owner February 4, 2026 06:03
@freeznet freeznet requested a review from Copilot February 4, 2026 06:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the Pulsar sinks tool to align configurations with the functions tool and adds end-to-end tests. The changes make tenant and namespace optional (defaulting to "public" and "default"), expand the tool's parameter set to support more sink configuration options, and introduce a new buildSinkConfig method that replaces the previous processArguments approach.

Changes:

  • Refactored sink configuration building with a new buildSinkConfig method that supports loading configuration from YAML files
  • Changed tenant and namespace from required to optional parameters with default values
  • Added support for 20+ new sink configuration parameters (cpu, ram, disk, custom-serde-inputs, secrets, etc.)
  • Added comprehensive e2e tests for create, update, get, and delete operations

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
pkg/mcp/builders/pulsar/sinks_parity_test.go New unit tests for sink configuration building, defaults, and validation
pkg/mcp/builders/pulsar/sinks.go Major refactoring of sink configuration logic with new parameters and improved validation
docs/tools/pulsar_admin_sinks.md Updated documentation to reflect optional tenant/namespace and new parameters
cmd/snmcp-e2e/main.go Added e2e test workflow for sink lifecycle (create, update, get, delete)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@freeznet freeznet merged commit 3466c9c into main Feb 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants