Allow Enhanced Broadcasting streams as recording parents#1739
Open
aleksandr-voitenko wants to merge 1 commit into
Open
Allow Enhanced Broadcasting streams as recording parents#1739aleksandr-voitenko wants to merge 1 commit into
aleksandr-voitenko wants to merge 1 commit into
Conversation
summeroff
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Recording and replay buffer outputs can depend on the active streaming output as their parent stream. Enhanced Broadcasting streams use separate JS/native wrapper classes, but they share the same underlying streaming UID contract as regular simple/advanced streaming outputs.
Before this change, the recording and replay buffer
streamingsetters only acceptedSimpleStreamingorAdvancedStreamingwrapper instances. When desktop tried to start recording while an Enhanced Broadcasting stream was active, the native client rejected the EB stream wrapper with errors like:Object is not a SimpleStreamingObject is not a AdvancedStreamingThis affected both Simple and Advanced output modes.
Changes
EnhancedBroadcastingSimpleStreamingas the parent stream for:SimpleRecordingSimpleReplayBufferEnhancedBroadcastingAdvancedStreamingas the parent stream for:AdvancedRecordingAdvancedReplayBufferSetStreaming.How Has This Been Tested?
Manually, Windows only.
Types of changes