Skip to content

Allow Enhanced Broadcasting streams as recording parents#1739

Open
aleksandr-voitenko wants to merge 1 commit into
release/0.26.28-1.21.3from
eb-recording-parent-streams
Open

Allow Enhanced Broadcasting streams as recording parents#1739
aleksandr-voitenko wants to merge 1 commit into
release/0.26.28-1.21.3from
eb-recording-parent-streams

Conversation

@aleksandr-voitenko

@aleksandr-voitenko aleksandr-voitenko commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Recording and replay buffer outputs can depend on the active streaming output as their parent stream. Enhanced Broadcasting streams use separate JS/native wrapper classes, but they share the same underlying streaming UID contract as regular simple/advanced streaming outputs.

Before this change, the recording and replay buffer streaming setters only accepted SimpleStreaming or AdvancedStreaming wrapper instances. When desktop tried to start recording while an Enhanced Broadcasting stream was active, the native client rejected the EB stream wrapper with errors like:

  • Object is not a SimpleStreaming
  • Object is not a AdvancedStreaming

This affected both Simple and Advanced output modes.

Changes

  • Allow EnhancedBroadcastingSimpleStreaming as the parent stream for:
    • SimpleRecording
    • SimpleReplayBuffer
  • Allow EnhancedBroadcastingAdvancedStreaming as the parent stream for:
    • AdvancedRecording
    • AdvancedReplayBuffer
  • Preserve the existing server-side contract by passing the accepted stream wrapper’s UID through SetStreaming.
  • Keep the JS object reference alive for EB stream wrappers, matching existing regular stream behavior.
  • Add OSN integration coverage for EB simple/advanced recording and replay buffer parent stream assignment.

How Has This Been Tested?

Manually, Windows only.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants