Skip to content

Add more ruff linter emulators - #129

Merged
mulkieran merged 4 commits into
stratis-storage:masterfrom
mulkieran:issue_project_900
Sep 29, 2026
Merged

mulkieran merged 4 commits into
stratis-storage:masterfrom
mulkieran:issue_project_900

Conversation

@mulkieran

@mulkieran mulkieran commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

the Mulhern added 4 commits September 28, 2026 20:06
Signed-off-by: the Mulhern <amulhern@amulhern.bos.csb>
Assisted-by: Claude:claude-sonnet-4-5
Signed-off-by: the Mulhern <amulhern@amulhern.bos.csb>
Assisted-by: Claude:claude-sonnet-4-5
Doing so has no effect

Signed-off-by: the Mulhern <amulhern@amulhern.bos.csb>
Signed-off-by: the Mulhern <amulhern@amulhern.bos.csb>
@mulkieran mulkieran self-assigned this Sep 29, 2026
@mulkieran mulkieran moved this to In Review in 2026September Sep 29, 2026
@mulkieran mulkieran added this to the 0.8.5 milestone Sep 29, 2026
@mulkieran

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-dbus-python-client-gen-129-copr_pull
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 18ea8228-957b-45a0-af69-d6dfeb934ecb

📥 Commits

Reviewing files that changed from the base of the PR and between 5a3bfb2 and 4fe97bd.

📒 Files selected for processing (4)
  • pyproject.toml
  • src/dbus_python_client_gen/__init__.py
  • src/dbus_python_client_gen/_errors.py
  • tests/test_generated.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The change enables additional Ruff rule sets, updates package imports and the DPClientInvocationContext declaration, and changes generated-class tests to access members directly.

Changes

Lint and code updates

Layer / File(s) Summary
Ruff configuration and code alignment
pyproject.toml, src/dbus_python_client_gen/__init__.py, src/dbus_python_client_gen/_errors.py, tests/test_generated.py
Ruff enables B and F alongside PL. Package imports use explicit same-name aliases, DPClientInvocationContext no longer inherits from ABC, and tests access generated members directly.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 4fe97

The added lint rules pass, and the documented invocation-context hierarchy remains intact. No concrete merge-blocking behavior change is established.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 4fe97

The exported context class loses abstract-base-class behavior, but the package still exports the same names and its internal invocation paths still use the existing context subclasses. No new security entry point or privilege change is evident. Compatibility for external users of the former base-class behavior is unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The identifiable affected surface is the exported context type and consumers of invocation errors; the inspected changes do not add a caller of a sensitive operation.

Trust Boundaries and Controls

  • observed — The inspected property and method invocation paths call a D-Bus proxy and construct concrete contexts when a D-Bus exception is caught; the PR’s context change does not modify those paths.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding more Ruff linter rule emulators. It is concise and related to the changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mulkieran
mulkieran merged commit 3b7e0ff into stratis-storage:master Sep 29, 2026
12 checks passed
@mulkieran
mulkieran deleted the issue_project_900 branch September 29, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant