fix(strandly): fix bootstrap ordering and update README#2402
Conversation
|
Assessment: Approve Clean, well-scoped fix. The bootstrap ordering change is correct — hatchling's Minor observations
|
e799367 to
7b98519
Compare
|
Assessment: Comment (Approve with minor suggestion) The core fix is correct and well-motivated — moving Review Notes
The bootstrap ordering fix and |
7b98519 to
1154532
Compare
|
Assessment: Approve Clean, well-scoped fix. The bootstrap reordering is correct — Details
|
- Move `pip install -e strands-py-wasm/` after build step since it requires strands-agent.wasm to exist - Add pgrayy-wasmtime to root pyproject.toml deps so generate step has access to wasmtime.component.bindgen - Remove _generated/ before regenerating to avoid FileExistsError - Fix stale test imports (StreamEvent moved to types module) - Update strands-wasm/README.md to use strandly commands and correct paths
1154532 to
75f6a6f
Compare
|
Assessment: Approve Well-scoped fix with correct ordering logic. Verified the full pipeline: No additional concerns beyond what existing reviews have noted. |
Summary
strandly bootstrapfailing on fresh clone —pip install -e strands-py-wasm/was running before the WASM component was built (hatchling needsstrands-agent.wasmto exist)pgrayy-wasmtimeto rootpyproject.tomldeps sostrandly generatehas access towasmtime.component.bindgenwithout needing strands-py-wasm installed first_generated/before regenerating to avoidFileExistsErrorstrands-py-wasm/tests/test_agent.py(StreamEventmoved totypesmodule)strands-wasm/README.mdto usestrandlycommands and correct pathsTest plan
strandly bootstrappasses from a completely clean state (no.venv/, nodist/, nogenerated/)