fix: do not synthesize exception for cancelled tools#2106
Open
Gastly wants to merge 1 commit intostrands-agents:mainfrom
Open
fix: do not synthesize exception for cancelled tools#2106Gastly wants to merge 1 commit intostrands-agents:mainfrom
Gastly wants to merge 1 commit intostrands-agents:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #2046 , setting
cancel_toolon aBeforeToolCallEventnow populatesAfterToolCallEvent.exceptionwith a synthesized exception which cannot be overwritten, causing tool cancellations to appear as failures to downstream hooks.Cancellation is a deliberate action, not a failure.
AfterToolCallEvent.cancel_messagealready exists to identify cancelled tools; hooks can use it to distinguish cancellations from genuine exceptions without needing a fake exception object. Additionally, tool result status remains aserrorfor cancellations.Span observability is preserved:
StatusCode.ERRORis now set by inspectingtool_result["status"]directly rather than relying on a synthesized exception.Public API Changes
AfterToolCallEvent.exceptionis once againNonefor cancelled tools.cancel_messageremains the correct field to detect cancellations.Related Issues
#2046
Documentation PR
No documentation changes needed.
Type of Change
Bug fix
Testing
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.