Skip to content

fix(bidi): respect role from BidiTextInputEvent instead of hardcoding user #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btdeviant wants to merge 4 commits into
base: main
Choose a base branch
from
+1 −1
Open

fix(bidi): respect role from BidiTextInputEvent instead of hardcoding user #2083

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fe59f7
fix(bidi): respect role from BidiTextInputEvent instead of hardcoding…
btdeviant Mar 22, 2026
91a06a6
Merge branch 'strands-agents:main' into fix/bidi-text-input-role
btdeviant Apr 7, 2026
ab325eb
Update versioning to dynamic in pyproject.toml
btdeviant Apr 7, 2026
940877a
chore: revert unrelated pyproject.toml whitespace change
btdeviant Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/strands/experimental/bidi/agent/loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ async def send(self, event: BidiInputEvent | ToolResultEvent) -> None:
await self._send_gate.wait()

if isinstance(event, BidiTextInputEvent):
message: Message = {"role": "user", "content": [{"text": event.text}]}
message: Message = {"role": event.role, "content": [{"text": event.text}]}
Copy link
Copy Markdown
Member

@pgrayy pgrayy Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate a bit more on the use case here? Note that we do allow you to prefill the initial message history that is sent to the model with assistant messages (Agent(messages=...)). They are sent separately in start(). Curious though what it would mean for the user to send an assistant message to the model in the middle of a conversation.

Copy link
Copy Markdown
Member

@pgrayy pgrayy Apr 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also ran some tests against 2 models (1 from google and 1 from openai). Google rejected the assistant message with an error response and openai seemed to ignore it.

Note, there is also some hardcoding of roles in the model providers themselves that I had to update for the tests.

Copy link
Copy Markdown
Author

@btdeviant btdeviant Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgrayy good catch on the Google test. Admittedly I'm using a custom adapter for an openai api compatible server (sglang / llama.cpp), and at the risk of being a bit presumptuous, I take your point that this PR may be premature given the official supported clients for BidiAgent are limited.

The use case it addresses is pushing context from async process as an input source, which through some other magic elicits unprompted engagement from the users perspective. A bit atypical I suppose. I can monkey patch around it, not a big deal, just took a bit of debugging to find out why assistant wasn't making it to the model - was a bit of a bear trap :)

await self._agent._append_messages(message)

await self._agent.model.send(event)
Expand Down
Loading