Adapt to latest ResilientFunctions API changes#11
Merged
Conversation
The Settings constructor dropped leaseLength and added replicaHeartbeatFrequency, and EffectId no longer converts implicitly from int. - Options: replace LeaseLength with ReplicaHeartbeatFrequency and pass Settings args by name; also stop dropping UtcNow in Merge - FlowsContainer: rebuild Options by name so no options are dropped - Tests: construct InitialEffect with EffectId via 0.ToEffectId() - Samples: use replicaHeartbeatFrequency instead of leaseLength Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the consuming code to compile and run against the latest
Cleipnir.ResilientFunctionssubmodule, which changed two APIs:Settingsconstructor droppedleaseLengthand addedreplicaHeartbeatFrequency(also shifting positional argument order).EffectIdno longer converts implicitly fromint.Changes
Cleipnir/Options.cs— replacedLeaseLengthwithReplicaHeartbeatFrequency(property, constructor parameter, XML doc), wired it throughMergeandMapToSettings, and switchedMapToSettingsto named arguments. Also fixed a latent bug whereMergesilently droppedUtcNow.Cleipnir/FlowsContainer.cs— the logger-injection path rebuiltOptionspositionally and dropped several settings; switched to named arguments so no options are lost.FunctionRegistrationTests,ParamlessFlowsTests,UnitFlowsTests) — constructInitialEffectwith anEffectIdvia0.ToEffectId().Cleipnir.Sample.AspNet,Cleipnir.Sample.Presentation.AspNet) — usereplicaHeartbeatFrequencyinstead ofleaseLength.Testing
dotnet build Cleipnir.NET.slnsucceeds.🤖 Generated with Claude Code