chore: onboard Apple1JS to LCD, retire SDD leftovers#178
Conversation
Add Lean Context Development artifacts (docs/lcd/MAP.md, DECISIONS.md, .claude/rules/lcd-conventions.md) and a CLAUDE.md triage pointer. Remove the retired SDD residue: docs/specs/, sdd-conventions.md, the stale absolute-path audit/parse permissions, and the now-obsolete SDD .gitignore block. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR adds the LCD framework: machine-block conventions, an append-only decisions log, an architecture map, updates CLAUDE.md with LCD guidance, and stops ignoring LCD artifact paths in .gitignore. ChangesLCD Framework Establishment
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/lcd/DECISIONS.md`:
- Around line 13-51: The decision headings (e.g., "D-005", "D-004", "D-003",
"D-002", "D-001") lack the required blank line after the "## ..." heading before
the bullet list, triggering MD022; fix by inserting a single blank line
immediately after each "## D-00X · <date> · <title>" heading so the list is
separated from the heading, or simply run the project formatter: execute yarn
lint:md:fix to auto-apply the spacing corrections across docs/lcd/DECISIONS.md.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f33a8d3b-588e-4577-9dce-d97ef34655ad
📒 Files selected for processing (5)
.claude/rules/lcd-conventions.md.gitignoreCLAUDE.mddocs/lcd/DECISIONS.mddocs/lcd/MAP.md
💤 Files with no reviewable changes (1)
- .gitignore
Add the blank line after each decision heading (D-001..D-005) before its bullet list, per CodeRabbit's MD022 (blanks-around-headings) finding on #178. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deploying apple1js with
|
| Latest commit: |
8d91c48
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7ecd6d63.apple1js.pages.dev |
| Branch Preview URL: | https://chore-lcd-onboard.apple1js.pages.dev |
Summary
Onboards Apple1JS to Lean Context Development (LCD) and removes the retired
Spec-Driven Development (SDD) scaffolding.
docs/lcd/MAP.md,docs/lcd/DECISIONS.md,.claude/rules/lcd-conventions.mdCLAUDE.md.gitignoreblock (sdd-conventions.md,docs/specs/)Docs/tooling only — no
src/code changed, so no version bump and no engine/test impact.Committed files verified free of private paths (public-repo safe).
Test plan
/Users/stid,claude-base,stid-sdd) — noneyarn test:cigate unaffected (eslint + type-check + vitest; no markdown in CI)🤖 Generated with Claude Code
Summary by CodeRabbit