Skip to content

chore: onboard Apple1JS to LCD, retire SDD leftovers#178

Open
stid wants to merge 2 commits into
masterfrom
chore/lcd-onboard
Open

chore: onboard Apple1JS to LCD, retire SDD leftovers#178
stid wants to merge 2 commits into
masterfrom
chore/lcd-onboard

Conversation

@stid
Copy link
Copy Markdown
Owner

@stid stid commented May 29, 2026

Summary

Onboards Apple1JS to Lean Context Development (LCD) and removes the retired
Spec-Driven Development (SDD) scaffolding.

  • Add LCD artifacts: docs/lcd/MAP.md, docs/lcd/DECISIONS.md, .claude/rules/lcd-conventions.md
  • Add an LCD triage pointer section to CLAUDE.md
  • Drop the obsolete SDD .gitignore block (sdd-conventions.md, docs/specs/)

Docs/tooling only — no src/ code changed, so no version bump and no engine/test impact.
Committed files verified free of private paths (public-repo safe).

Test plan

  • No application code changed (5 docs/config files)
  • New files scanned for private path leaks (/Users/stid, claude-base, stid-sdd) — none
  • yarn test:ci gate unaffected (eslint + type-check + vitest; no markdown in CI)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added LCD conventions and constraint guidance for machine-blocks and workflows
    • Added Lean Context Development (LCD) guidance with artifact locations and resume workflow notes
    • Added an append-only architectural decision log with initial core-technology entries
    • Added a comprehensive architecture map outlining components, responsibilities, and entry points
    • Updated ignore rules to begin tracking spec-related documentation paths

Review Change Stack

Add Lean Context Development artifacts (docs/lcd/MAP.md, DECISIONS.md,
.claude/rules/lcd-conventions.md) and a CLAUDE.md triage pointer.
Remove the retired SDD residue: docs/specs/, sdd-conventions.md, the
stale absolute-path audit/parse permissions, and the now-obsolete
SDD .gitignore block.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2c41f9dc-d771-4f4a-b96e-7efcfcade3f5

📥 Commits

Reviewing files that changed from the base of the PR and between cedce7d and 8d91c48.

📒 Files selected for processing (1)
  • docs/lcd/DECISIONS.md
✅ Files skipped from review due to trivial changes (1)
  • docs/lcd/DECISIONS.md

📝 Walkthrough

Walkthrough

This PR adds the LCD framework: machine-block conventions, an append-only decisions log, an architecture map, updates CLAUDE.md with LCD guidance, and stops ignoring LCD artifact paths in .gitignore.

Changes

LCD Framework Establishment

Layer / File(s) Summary
LCD Machine Block Conventions
.claude/rules/lcd-conventions.md
Defines machine-block configuration specifying artifact paths, Vitest test discovery rules, and exact Yarn commands for scoped runs and CI gating. Documents key meanings and constitution notes restating project constraints for branching, dual-engine parity, type safety, version bumps, contract scoping, formatter usage, and WASM optimization.
LCD Artifact Exposure and Entry Points
.gitignore, CLAUDE.md
Stops ignoring .claude/rules/sdd-conventions.md and docs/specs/ paths. Adds LCD section to CLAUDE.md documenting triage workflow invocation, artifact locations under docs/lcd/, and context-reset resume commands.
Architectural Decisions Log
docs/lcd/DECISIONS.md
Establishes append-only decision log with decisions D-001 through D-005 covering Worker-hosted CPU loop with comlink messaging, WASM speed-first optimization, dual 6502 engines with runtime switching and parity testing, Vitest adoption, and Yarn package manager selection. Includes template and next-id marker for future decisions.
Architecture Map
docs/lcd/MAP.md
Documents project architecture covering browser-based dual-engine shape (JS + Rust/WASM), zone and component responsibilities with guardrails, entry points and exposed surfaces, core invariants, and references to conventions and gate rules. Includes refresh triggers for regeneration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • stid/Apple1JS#164: Both PRs touch .gitignore entries for .claude/rules/sdd-conventions.md and docs/specs/, affecting exposure of spec and machine-specific artifact paths.

Poem

🐰 A framework blooms with LCD's glow,
Decisions logged, and maps laid low,
Conventions guide the working way,
Machine blocks hum, docs/lcd/ at play,
Context flows where builders go! 🌱

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: onboarding Apple1JS to LCD methodology and removing retired SDD artifacts, which aligns with the primary objectives of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/lcd-onboard

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/lcd/DECISIONS.md`:
- Around line 13-51: The decision headings (e.g., "D-005", "D-004", "D-003",
"D-002", "D-001") lack the required blank line after the "## ..." heading before
the bullet list, triggering MD022; fix by inserting a single blank line
immediately after each "## D-00X · <date> · <title>" heading so the list is
separated from the heading, or simply run the project formatter: execute yarn
lint:md:fix to auto-apply the spacing corrections across docs/lcd/DECISIONS.md.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f33a8d3b-588e-4577-9dce-d97ef34655ad

📥 Commits

Reviewing files that changed from the base of the PR and between 9fb8639 and cedce7d.

📒 Files selected for processing (5)
  • .claude/rules/lcd-conventions.md
  • .gitignore
  • CLAUDE.md
  • docs/lcd/DECISIONS.md
  • docs/lcd/MAP.md
💤 Files with no reviewable changes (1)
  • .gitignore

Comment thread docs/lcd/DECISIONS.md
Add the blank line after each decision heading (D-001..D-005) before its
bullet list, per CodeRabbit's MD022 (blanks-around-headings) finding on #178.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 30, 2026

Deploying apple1js with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8d91c48
Status: ✅  Deploy successful!
Preview URL: https://7ecd6d63.apple1js.pages.dev
Branch Preview URL: https://chore-lcd-onboard.apple1js.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant