Add method to shutdown server#441
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
- Coverage 99.69% 99.43% -0.27%
==========================================
Files 109 109
Lines 2648 2667 +19
Branches 332 335 +3
==========================================
+ Hits 2640 2652 +12
- Misses 7 13 +6
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Also there's no way to test this code using ST2 - could you add action yamls to wrap both calls so I can test on a dev ST2 instance? |
DavidFair
left a comment
There was a problem hiding this comment.
Making this a formal review
Needs unit testing (even in the PR template)
Needs to be runnable on a dev instance else we're working on hopes and prayers (again in the PR template)
Before we accept code into ST2 where it can run on a prod instance with elevated permissions automatically in the future....
4266b4e to
77eda60
Compare
Add a new function to shutdown a single VM or server. This function will be used on new actions. For example, to shutdown all servers in a given hypervisor. A unit test function to validate that an Exception is raised when the servers goes to ERROR state has been implemented.
c76dcad to
2318af3
Compare
Description:
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?