Added remaining F2008 intrinsics#518
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #518 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 89 89
Lines 13886 13900 +14
=======================================
+ Hits 12810 12824 +14
Misses 1076 1076 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@sergisiso @arporter Ready for a look. |
arporter
left a comment
arporter
left a comment
There was a problem hiding this comment.
Good job Aidan, thanks for tackling this. I attempted to be thorough and think I found two mistakes.
We also need some tests... :-)
| } | ||
|
|
||
| f08_other_intrinsics = { | ||
| "STORAGE_SIZE": {"min": 1, "max": 3}, |
|
|
||
| f08_other_intrinsics = { | ||
| "STORAGE_SIZE": {"min": 1, "max": 3}, | ||
| "PARITY": {"min": 1, "max": 2}, |
There was a problem hiding this comment.
Same here (if https://fortran-lang.org/learn/intrinsics/transform/#parity is to be believed).
| generic_function_names.update(f08_bessel_functions) | ||
|
|
||
| specific_function_names = F2003_Intrinsic_Name.specific_function_names | ||
|
|
There was a problem hiding this comment.
You need some tests :-) One for each new group added here will do I think. We could probably ask Claude to write a whole suite of tests for all of the intrinsics if you fancy trying that? Or could be a challenge for Hannah?
arporter
added
reviewed with actions
2 participants
This adds all the new F2008 intrinsics. There are some potential extensions to previously existing intrinsics I didn't include, but I wasn't certain enough of those to add them in this PR.
All intrinsics taken from https://wg5-fortran.org/N1851-N1900/N1891.pdf and checked with gcc docs if I was unsure about arguments.