(Closes #2917) COMMON BLOCK support for real(kind=x)#3393
Open
schreiberx wants to merge 2 commits intomasterfrom
Open
(Closes #2917) COMMON BLOCK support for real(kind=x)#3393schreiberx wants to merge 2 commits intomasterfrom
schreiberx wants to merge 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3393 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 387 387
Lines 54310 54313 +3
=======================================
+ Hits 54288 54291 +3
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@schreiberx I just had a quick look - is this missing some files? I'm confused how the test passes but all this PR contains at the moment is a new test and not new functionality. |
Collaborator
Author
|
Yes, it's just adding a test as from #2917 . Seems like it's already supported. I just added this to close the issue. |
Member
|
Hi @schreiberx, thanks for this (you beat me to it). I don't think we need a brand new test though - it's sufficient to just add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #2917