Skip to content

fix(mcp): restrict stdio server environment - #208

Merged
liuedcson merged 1 commit into
mainfrom
codex/fix-mcp-stdio-safe-env
Sep 30, 2026
Merged

liuedcson merged 1 commit into
mainfrom
codex/fix-mcp-stdio-safe-env

Conversation

@liuedcson

Copy link
Copy Markdown
Collaborator

Summary

  • inherit only the MCP SDK safe default environment for stdio servers
  • preserve explicitly declared server variables and the Step login credential fallback
  • update plugin diagnostics so they no longer suggest exporting variables that will not be inherited
  • add regression coverage proving unrelated parent-process secrets are excluded

Testing

  • pnpm --filter @step-harness/coding-agent exec vitest --run src/step/mcp.test.ts test/step-plugins.test.ts
  • pnpm --filter @step-harness/coding-agent test
  • pnpm run check

@liuedcson
liuedcson merged commit ec1cd22 into main Sep 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant