fix: tighten MCP config redaction and config-scan symlink handling - #191
Open
swarit-stepsecurity wants to merge 2 commits into
Open
fix: tighten MCP config redaction and config-scan symlink handling#191swarit-stepsecurity wants to merge 2 commits into
swarit-stepsecurity wants to merge 2 commits into
Conversation
env and headers were dropped outright, but a credential embedded in the server URL or in an args flag passed through unredacted.
…cans .npmrc/.yarnrc(.yml)/bunfig.toml discovered while walking project directories could be a symlink to an unrelated file elsewhere on disk; the scan would follow it and include the target's contents in the audit. Project-scope symlinks are now recorded but not read through. User/global/builtin scope files are unaffected.
Member
Author
|
cc: @ashishkurmi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small hardening fixes found during a recent assessment:
Both include regression tests.