-
Notifications
You must be signed in to change notification settings - Fork 353
Add SEP-45 pubnet contract deployment #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b4458b4 to
060276b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a pubnet deployment address for the SEP-45 web authentication contract to the documentation. The contract has been deployed to pubnet as part of the sep45-reference v0.1.3 release.
Changes:
- Updates the Implementations section in SEP-0045 to document the pubnet contract address
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leighmcculloch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
| - Wasm hash: | ||
| `3c8d0b8b347752e57abe0b50380401ca8f5793bc971b685fd072571bbf5d54cc` | ||
| - Deployed code: | ||
| https://github.com/stellar/sep45-reference/blob/3dcabc965f01512a631d2c0c6999786f5f6a01cd/contracts/web_auth/src/lib.rs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified:
$ gh attestation verify --owner stellar contract.wasm
Loaded digest sha256:3c8d0b8b347752e57abe0b50380401ca8f5793bc971b685fd072571bbf5d54cc for file://contract.wasm
Loaded 1 attestation from GitHub API
The following policy criteria will be enforced:
- Predicate type must match:................ https://slsa.dev/provenance/v1
- Source Repository Owner URI must match:... https://github.com/stellar
- Subject Alternative Name must match regex: (?i)^https://github.com/stellar/
- OIDC Issuer must match:................... https://token.actions.githubusercontent.com
✓ Verification succeeded!
The following 1 attestation matched the policy criteria
- Attestation #1
- Build repo:..... stellar/sep45-reference
- Build workflow:. .github/workflows/release.yml@refs/tags/v0.1.3
- Signer repo:.... stellar/sep45-reference
- Signer workflow: .github/workflows/release.yml@refs/tags/v0.1.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this merged I had the thought we should add the link to the attestation so its easier to find it again. Adding it in:
This adds a pubnet instance of the SEP-45 web auth contract.
The Wasm was built as part of a sep45-reference release but is currently showing up as not verified, both the CLI and the lab, due to an issue with SEP-55 described in stellar/stellar-cli#2358
The build can be verified manually using the GH CLI until it's resolved.