Add SLP-4 #1838
Merged
Add SLP-4 #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Jan 13, 2026
anupsdf
reviewed
Jan 13, 2026
| ## Preamble | ||
|
|
||
| ``` | ||
| SLP: 0003 |
Member
There was a problem hiding this comment.
Thanks for catching that. We should get copilot to review prs for things like this. 🤔
| | Write Entries | 50 | 200 | 500 | 1000 | 5 | | ||
| | Write Bytes | 132096 | 132096 | 143360 | 286720 | 2.17 | | ||
| | Tx Size Bytes | 132096 | 132096 | 133120 | 266240 | 2.01 | | ||
| | Instructions/threads | 100'000'000 | 400'000'000 | 600'000'000 / 1 thread | 580'000'000 / 2 threads | 2.9 | |
Contributor
There was a problem hiding this comment.
New Ledger/Tx Ratio would be 1.45, not 2.9? i.e. 580M/400M
Contributor
Author
There was a problem hiding this comment.
No, it's 2 * 580 / 400 == 2.9. We have 2 threads in this proposal.
|
|
||
| Note, that the close time has increased since SLP-3. Given that the network performance hasn't degraded since then, we propose to relax the threshold for the Soroban apply time to 300ms. The previous threshold of 250ms was very conservative, and a relatively small increase to it shouldn't be able to compromise the network stability. | ||
|
|
||
| ### Benchmarking with proposed limits |
Contributor
There was a problem hiding this comment.
How about adding 400M benchmark numbers in the list below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.