Skip to content

Remove unused dependencies and dead code - #2760

Open
leighmcculloch wants to merge 2 commits into
mainfrom
remove-unused-cli-deps
Open

leighmcculloch wants to merge 2 commits into
mainfrom
remove-unused-cli-deps

Conversation

@leighmcculloch

Copy link
Copy Markdown
Member

What

Remove unused dependencies across soroban-cli, stellar-ledger, soroban-spec-typescript, soroban-spec-tools and soroban-test, along with a no-op build script function and stale allow attributes.

Why

The compiler's unused_crate_dependencies lint and a code search show nothing uses them, and they add build time and lockfile churn.

Known limitations

N/A

@leighmcculloch
leighmcculloch requested review from a team and a lite review from Copilot September 28, 2026 02:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The only remaining feedback is a non-blocking cleanup nit.

Review effort: Lite
Findings: None

What changed in this PR

Removes unused dependencies, stale lint allowances, and no-op build logic across the workspace.

Changes:

  • Cleans unused dependencies and updates Cargo.lock.
  • Restricts test-only helpers and removes obsolete allowances.
  • Removes no-op build-script logic.
File Summary
cmd/​soroban-cli/​src/​utils.rs Restricts a helper to tests.
cmd/​soroban-cli/​src/​print.rs Removes stale dead-code allowances.
cmd/​soroban-cli/​Cargo.toml Removes unused dependencies.
cmd/​soroban-cli/​build.rs Removes no-op build logic; a matching helper remains elsewhere as a nit.
cmd/​crates/​stellar-ledger/​src/​emulator_test_support/​speculos.rs Removes stale allowances.
cmd/​crates/​stellar-ledger/​src/​emulator_test_support/​http_transport.rs Removes stale allowance.
cmd/​crates/​stellar-ledger/​Cargo.toml Removes unused dependencies.
cmd/​crates/​soroban-test/​Cargo.toml Removes unused dependencies.
cmd/​crates/​soroban-spec-typescript/​Cargo.toml Removes unused dependencies.
cmd/​crates/​soroban-spec-tools/​Cargo.toml Removes unused dev-dependencies.
Cargo.toml Removes unused workspace dependencies.
Cargo.lock Updates the resolved dependency graph.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog (Not Ready)

Development

Successfully merging this pull request may close these issues.

2 participants