Reduce qualified type and event names

[leighmcculloch]

Note

Part of a stack of PRs listed here:

• Fixing a few issues with the soroban-sdk's production of specs (type ids, name collisions, aliasing, ...) stellar-protocol#2014

What

Reduce the fully qualified UDT type names that stellar/rs-soroban-sdk#1970 emits (e.g. my_contract::inner::State) down to short names during the build process.

Why

The soroban-sdk will be emitting fully qualified user-defined type names as an intermediary step so that the stellar-cli can reduce the spec to only those types needed by the exported interface of a contract, and so that types will be guaranteed to have unique names. The long names are not good for most tooling though which is already accustomed to the short simple names. The cli can make this change in the soroban-sdk a no-op for the rest of the ecosystem by converting the names to unique simple names during the build step.

[Copilot]

Copilot review overview

🟡 Changes recommended

Address unresolved reference handling, warning sanitization, image-path behavior, collision messaging, and integration coverage.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings · New
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Multiple moderate issues remain unresolved in the build path, diagnostics, safety, and test coverage.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved moderate issues affect correctness, coverage, and safe warning output.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Multiple moderate issues remain in build-path handling, serialization, diagnostics, and test coverage.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Multiple moderate issues remain in build coverage, reduction behavior, warning safety, and test coverage.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Moderate issues remain in reference handling, warning sanitization, container builds, and integration coverage.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved build-path, fast-path, sanitization, naming, and coverage issues remain.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Address the missed undefined-type rewrites and sanitize spec-derived warning names.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Address artifact handling, reference reduction, output sanitization, and end-to-end build coverage.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Five unresolved moderate findings remain across build-path coverage, safety, testing, and warning accuracy.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names