Use shared claude-review reusable workflow#2580
Conversation
There was a problem hiding this comment.
Pull request overview
Replaces the inlined Claude review workflow with a call to the shared reusable workflow in stellar/actions, and narrows trigger types to ready_for_review and synchronize.
Changes:
- Switch
.github/workflows/claude-review.ymlto usestellar/actions/.github/workflows/claude-review.yml@main. - Pass
ANTHROPIC_API_KEYviasecrets:to the reusable workflow. - Narrow
pull_requesttrigger types from 4 to 2.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f0975041f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, ready_for_review, reopened] | ||
| types: [ready_for_review, synchronize] |
There was a problem hiding this comment.
Restore
opened pull_request trigger
Restricting pull_request.types to ready_for_review and synchronize skips the initial review for PRs opened as non-draft, because ready_for_review only fires when a draft is explicitly converted to ready. In this configuration, a normal PR opened in ready state will not run Claude review until a later push triggers synchronize, which is a functional regression from the previous behavior and can leave first-pass changes unreviewed.
Useful? React with 👍 / 👎.
What
Replace the inlined
claude-review.ymlworkflow with a call to the shared reusable workflow atstellar/actions/.github/workflows/claude-review.yml@main. Keep the existingpull_requesttrigger (the safer default; fork PRs can't access secrets on this event so they cannot be reviewed) and narrow the trigger types to[ready_for_review, synchronize]so Claude only reviews PRs that are marked ready and re-reviews on new commits.Why
The same claude-review workflow is maintained across four stellar repos. Moving to
stellar/actionslets all repos share one implementation, so the security model and prompt updates live in one place. The reusable workflow also adopts the harderpull_request_targetflow with an author-association gate, enabling reviews of fork PRs from org members while still keeping secrets out of attacker-controlled code paths.Example
Before — fully inlined workflow with
pull_requesttrigger.After:
Note
Requires the corresponding PR in
stellar/actionsto be merged first so thatstellar/actions/.github/workflows/claude-review.yml@mainresolves: