Conversation
Adopt the logo renderer and SVG packaging from #3795 independently of #3794 and #3799. Share compact text segments with the existing summary so quota selection, display mode, ordering, and overflow stay unchanged. Preserve text fallback for missing logos and older IPC backends. Closes #3795 Refs #3794 Co-authored-by: jsonMartin <4033621+jsonMartin@users.noreply.github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 22, 2026, 12:49 AM ET / 04:49 UTC. ClawSweeper reviewWhat this changesAdds theme-tinted provider logos to Omarchy’s compact usage bar, packages the existing SVG assets, and preserves text fallbacks and quota formatting. Merge readiness✅ Ready for maintainer review Keep open: this is a useful, owner-sponsored adaptation that is absent from current main and the latest release. No actionable correctness or security defect was found. Priority: P3 Review scores
Verification
How this fits togetherThe Linux desktop backend turns CLI usage results into a local snapshot consumed by the Omarchy bar. The bar combines formatted quota entries with installed provider logos while the backend continues to own polling and settings. flowchart LR
A[CLI usage results] --> B[Linux desktop backend]
C[Display preferences] --> B
B --> D[Local usage snapshot]
D --> E[Omarchy bar]
F[Installed provider logos] --> E
E --> G[Logo or text with compact quota]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep logo rendering as a thin presentation layer over the existing compact quota model, with local assets and backward-compatible text fallbacks. Do we have a high-confidence way to reproduce the issue? Not applicable: this adds provider-logo presentation rather than repairing a reported bug; source inspection confirms main and v0.64.0 use text tags. Is this the best way to solve the issue? Yes: extracting the existing compact segments avoids competing quota logic and cleanly separates this feature from the wider quota-and-pace proposal. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against b99a91694d78. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Adopt the logo renderer and SVG packaging from #3795 independently of #3794 and #3799. Share compact text segments with the existing summary so quota selection, display mode, ordering, and overflow stay unchanged. Preserve text fallback for missing logos and older IPC backends. Closes #3795 Refs #3794 Co-authored-by: jsonMartin <4033621+jsonMartin@users.noreply.github.com> (cherry picked from commit b6c59b6)
Adopt the logo renderer and SVG packaging from #3795 independently of #3794 and #3799. Share compact text segments with the existing summary so quota selection, display mode, ordering, and overflow stay unchanged. Preserve text fallback for missing logos and older IPC backends. Closes #3795 Refs #3794 Co-authored-by: jsonMartin <4033621+jsonMartin@users.noreply.github.com> (cherry picked from commit b6c59b6)
Omarchy currently identifies providers only by text tags. Adopt @jsonMartin's logo renderer and SVG packaging from #3795, with structured
barEntriessupplied by the existing Linux backend. Missing logos and older backends keep the text fallback; dark SVGs are tinted to the bar foreground.This standalone adaptation preserves the current compact quota, used/remaining preference, ordering, two-entry limit and
+Ncount. Provider fetching and authentication remain in Core/CLI. It does not require #3794 or #3799. The wider quota/weekly-pace layout in #3794 remains a separate maintainer decision.Validation:
node --test Integrations/Omarchy/test.mjs Integrations/Omarchy/notifications.test.mjs: 29 passed. The two new structured-label tests failed before implementation (27 passed, 2 failed), then passed.python3 Integrations/Omarchy/test_install.py: 6 passed; added logo check failed before implementation.python3 Integrations/Linux/tests/test_package.py: 3 passed locally and on Linux; added archive check failed before implementation. Verifies exact current SVG filenames and bytes, including archive installation/reinstallation without a checkout.qmake6 ../../Integrations/Linux/codexbar-linux.pro && make -j2, thenpython3 Integrations/Linux/tests/test_desktop.py: 16 passed with a fake CLI and isolated HOME/XDG directories.qmake6 ../../Integrations/Linux/tests/accounts.pro && make -j2 && ./tst_accounts: 3 passed, 0 failed.make check: passed; SwiftLint reported 0 violations in 2547 files. The first run hit an unchanged process-cleanup timing test; the focused retry and full rerun passed.swift build --jobs 2:Build complete! (942.55 sec); no release build or app launch.Scope: 206 insertions and 14 deletions across 13 files;
Sources/,WidgetExtension/, andTests/are unchanged. Relevant coverage lives underIntegrations/.Closes #3795
Refs #3794