chore: land triage train 2 (#3825 #3826 #3828 #3829)

[steipete]

Integrates the four reviewed wave-2 lanes in one PR to avoid repeated changelog conflicts and competing macOS CI runs. The five lane commits retain their original authors, bodies, human co-author trailers, and cherry-pick provenance, with the lane PR number appended to each subject. The seven-commit stack also retains the Kimi regional-subtitle test correction and the existing regeneration commit.

Lane verdicts

• fix(menu): name status items before sizing and bound saved positions #3825 — Status-item ordering and bounded placement repair: create zero-length items, assign stable names before sizing, and repair matching saved positions beyond the widest display plus the existing margin. KEEP OPEN Status bar items jump to leftmost (hidden) on restart — corrupted NSStatusItem Preferred Position values #3355 and Restarting CodexBar creates a new Bartender item identity and resets it to Always Hidden #3201: recurring position-write attribution and Bartender identity persistence still need signed runtime evidence. Includes the lane's follow-up architecture-anchor correction.
• fix(kimi): support regional usage and dashboard hosts #3826 — LAND / fixes Kimi: Usage Dashboard link hardcodes China-region kimi.com; global accounts are on kimi.ai #3752: route Kimi usage, cookie discovery, settings links, and dashboards by China or International region. China remains the default; unscoped CLI credentials stay China-only. Thanks @LPFchan.
• fix(crof): remove provider after shutdown #3828 — LAND / adopts Remove Crof provider after shutdown #3657: remove Crof after shutdown, reuse unknown-provider config handling, preserve config bytes on read, and drop retired entries on the next save. Retains HelmCode from train 1: the integrated registry has 77 providers. Thanks @baanish; original human co-author credit is preserved.
• feat(cursor): pin Grok Bot usage in menu-bar layouts #3829 — LAND / adopts Add Grok Bot layout token #3712; fixes Menu bar: pin Cursor Grok Bot weekly usage (extra lane or status item) #3309: expose Cursor's Grok Bot % layout token, hide unavailable allowances, refresh when the allowance changes, and preserve older-version layout projections. Thanks @yicone; original human co-author credit is preserved.

Integration

Preserves main's new Highlights section, every Unreleased bullet, and contributor thanks, Kimi dashboard routing alongside HelmCode, and train 1's widget-label switch refactor with only Crof removed. Provider documentation and localized site counts use 77; the capability audit's separate totals are calculated from its audited rows. Architecture anchors and widget fingerprints are checked against the combined sources.

Validation

• Registry, both provider manifests, generated provider IDs, and README provider entries independently agree on 77 providers, retaining HelmCode, v0, and TypeSafe after Crof removal. All 69 provider-count strings across 23 site locales use 77.
• All four prescribed generators passed with no drift. Main already contains the formerly missing HelmCode icon. The existing regeneration commit contains the formatting-only wrap of the corrected Kimi subtitle test; the concatenated expected value is unchanged.
• swift build --jobs 4 passed.
• make check passed: zero SwiftLint violations across 2,547 files; all repository checks passed. Its first run caught only the corrected subtitle assertion's 123-character line, fixed by the wrap above.
• The expanded focused command below passed 574 tests (561 app tests plus 13 plugin/portable tests), with three opt-in UI proof tests skipped and zero failures. No full sharded suite or live provider/Keychain probe ran.
• Independent Codex rebase review and the formatting-only amendment review both finished scoped-clean through P2.
• The coordinator's Kimi test patch retains the same stable patch ID. All seven commit messages, original authors, author dates, and human trailers are preserved.

CODEXBAR_SUPPRESS_TEST_KEYCHAIN_ACCESS=1 swift test --jobs 4 --no-parallel --filter 'ProviderArchitectureGatekeeperTests|ProviderPluginParityTests|UserProviderPluginPortableTests|ProviderSettingsDescriptorTests|StatusItemCreationOrderingTests|MenuBarStatusItem|Kimi|CodexBarConfigUnknownProviderTests|MenuBarLayout|CodexBarWidgetProviderTests|WidgetSnapshotTests|CLIUsage|Providers'

Widget color fingerprints reflect the 77-provider registry, and the architecture gatekeeper passes with the merged provider metadata and anchors.

Existing synthetic UI proof

Cursor Grok Bot layout, captured and inspected in #3829:

Before:

After:

Kimi's synthetic settings renders and all lane verdict evidence remain in the coordinator's local lane reports. The status-item changes make no claim of completed Bartender runtime verification.

Closes #3825
Closes #3826
Closes #3828
Closes #3829
Fixes #3752
Closes #3657
Fixes #3309
Closes #3712

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: needs maintainer review before merge. Reviewed September 21, 2026, 1:17 PM ET / 17:17 UTC (Revision 3).

ClawSweeper review

What this changes

The branch improves menu-bar item creation and placement repair, adds Kimi region selection and Cursor Grok Bot percentages, and removes the retired Crof provider.

Merge readiness

✅ Ready for maintainer review

This remains useful, owner-sponsored integration work. No actionable introduced defect was found, and the earlier conflict and regeneration concerns are resolved.

Priority: P2
Reviewed head: 5b08ff9721404374b158331aec5f2a5070d11dc3

Review scores

Measure	Result	What it means
Overall readiness	🐚 platinum hermit (4/6)	A coherent integration with focused compatibility coverage and no actionable correctness finding; proof limits are stated accurately.
Proof confidence	🌊 off-meta tidepool	Not applicable: The OWNER-authored PR is exempt from the external-contributor proof gate. Inspected synthetic renderer images show Grok Bot output, and the Crof lane reports isolated CLI config preservation; neither establishes live Kimi requests or Bartender persistence, which the owner does not claim.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Verification

Check	Result	Evidence
Real behavior	Not applicable	Not applicable: The OWNER-authored PR is exempt from the external-contributor proof gate. Inspected synthetic renderer images show Grok Bot output, and the Crof lane reports isolated CLI config preservation; neither establishes live Kimi requests or Bartender persistence, which the owner does not claim.
Evidence reviewed	13 items	Repository policy: Read the complete root AGENTS.md; no nested AGENTS.md or matching maintainer-note files were found. Applied the guidance on provider isolation, settings compatibility, focused model tests, and avoiding unsolicited Keychain access. This review ran no builds, tests, generators, or provider probes. Pinned introduction and integration: Reviewed merge-base 94ca725 to head 5b08ff9. The complete local delta contains 112 files, with 1,533 additions and 1,538 deletions. Earlier merge conflict resolved: Raw test-merge parents are exactly pinned main followed by pinned PR head. GitHub's comparison confirms that the merge preserves main's Hugging Face changes and changelog entry. Local inspection of one merge blob failed with a promisor-fetch HTTP 403; the read-only GitHub comparison supplied the missing merge evidence.
Findings	None	None.
Security	None	None.

How this fits together

CodexBar combines provider credentials and usage responses with saved preferences to display usage in the macOS menu bar. These changes affect regional requests, available providers, saved layouts, and status-item placement.

flowchart LR
  A[Credentials and region] --> B[Provider requests]
  B --> C[Usage snapshots]
  D[Saved layout preferences] --> E[Compatible layout loading]
  C --> F[Menu-bar renderer]
  E --> F
  G[Saved positions and displays] --> H[Status-item creation]
  F --> H

Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

Metric	Value	Why it matters
Production and test delta	Production +492/−737 (net −245); tests +895/−643 (net +252)	The feature additions are offset by retired-provider removal and helper reuse, with added compatibility and routing coverage.
Layout compatibility	1 new storage generation; 3 older projections retained	V4 adds named usage tokens while preserving layouts readable by earlier releases.

Technical review

Best possible solution:

Retain the shared provider and layout implementations with their compatibility projections, while keeping recurring placement corruption and Bartender identity persistence tracked separately.

Do we have a high-confidence way to reproduce the issue?

Yes for the source-level Kimi routing and missing Grok Bot layout capability; current main exposes those gaps. Recurring position corruption and Bartender identity changes have not been reproduced by this review.

Is this the best way to solve the issue?

Yes: the branch extends existing provider settings, descriptor capabilities, and persistence projections instead of creating competing implementations, and its intentional compatibility changes are documented and owner-approved.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 35d479eafd3f.

Labels

Label changes:

• add proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence. The OWNER-authored PR is exempt from the external-contributor proof gate. Inspected synthetic renderer images show Grok Bot output, and the Crof lane reports isolated CLI config preservation; neither establishes live Kimi requests or Bartender persistence, which the owner does not claim.

Label justifications:

• P2: This combines bounded provider and menu-bar improvements without evidence of an urgent widespread failure.
• merge-risk: 🚨 compatibility: The owner explicitly accepts removing retired Crof entries on save and clearing menu-manager parking positions beyond the new bound; older layout projections are retained and covered.
• rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The OWNER-authored PR is exempt from the external-contributor proof gate. Inspected synthetic renderer images show Grok Bot output, and the Crof lane reports isolated CLI config preservation; neither establishes live Kimi requests or Bartender persistence, which the owner does not claim.
• proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence. The OWNER-authored PR is exempt from the external-contributor proof gate. Inspected synthetic renderer images show Grok Bot output, and the Crof lane reports isolated CLI config preservation; neither establishes live Kimi requests or Bartender persistence, which the owner does not claim.

Evidence

What I checked:

• Repository policy: Read the complete root AGENTS.md; no nested AGENTS.md or matching maintainer-note files were found. Applied the guidance on provider isolation, settings compatibility, focused model tests, and avoiding unsolicited Keychain access. This review ran no builds, tests, generators, or provider probes. (AGENTS.md:1, 5b08ff972140)
• Pinned introduction and integration: Reviewed merge-base 94ca725 to head 5b08ff9. The complete local delta contains 112 files, with 1,533 additions and 1,538 deletions. (5b08ff972140)
• Earlier merge conflict resolved: Raw test-merge parents are exactly pinned main followed by pinned PR head. GitHub's comparison confirms that the merge preserves main's Hugging Face changes and changelog entry. Local inspection of one merge blob failed with a promisor-fetch HTTP 403; the read-only GitHub comparison supplied the missing merge evidence. (87aff1f44843)
• Work remains necessary: Pinned main and release v0.63.0 both retain Kimi settings without a region field. The verified merge comparison also retains the train's layout, placement, and Crof changes as additions to main; the supplied related implementation PRs remain open. (Sources/CodexBarCore/Providers/Kimi/KimiProviderSettings.swift:3, f3e718c897d5)
• Saved-layout upgrade coverage: V4 persistence retains older-readable projections. The added tests cover loading existing V3 preferences, preserving reset selections, unchanged downgrades, older-version edits, provider removal from overrides, and deliberate conditional-library clearing. (Tests/CodexBarTests/MenuBarLayoutV4PersistenceTests.swift:5, 5b08ff972140)
• Accepted placement compatibility tradeoff: The OWNER-authored lane explicitly accepts clearing menu-manager parking positions beyond the widest display plus 512 points: fix(menu): name status items before sizing and bound saved positions #3825. The integrated implementation and documentation retain that exact scope. The owner expressly leaves Status bar items jump to leftmost (hidden) on restart — corrupted NSStatusItem Preferred Position values #3355 and Restarting CodexBar creates a new Bartender item identity and resets it to Always Hidden #3201 open because recurring writes and Bartender identity persistence remain unproven. (docs/DEVELOPMENT.md:131, 5b08ff972140)

Likely related people:

• unknown: The claimed source-line change could not be verified from bounded local history. (role: source history unknown; confidence: low)
• unknown: The claimed source-line change could not be verified from bounded local history. (role: source history unknown; confidence: low)

Rating scale

Score	Internal tier	Crab rank	Meaning
6/6	S	🦀 challenger crab	Exceptional readiness
5/6	A	🦞 diamond lobster	Very strong readiness
4/6	B	🐚 platinum hermit	Good normal PR; ordinary maintainer review
3/6	C	🦐 gold shrimp	Useful, but confidence is limited
2/6	D	🦪 silver shellfish	Proof or implementation needs work
1/6	F	🧂 unranked krab	Not merge-ready
N/A	NA	🌊 off-meta tidepool	Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (2 earlier review cycles)

• reviewed 2026-09-21T11:33:36.835Z sha 1bb2ec7 :: needs maintainer review before merge. :: none
• reviewed 2026-09-21T15:57:39.076Z sha 0ee064b :: needs changes before merge. :: none