Skip to content

Add Qwen Code provider#248

Open
brenorb wants to merge 1 commit intosteipete:mainfrom
brenorb:upstream-pr/qwen-code
Open

Add Qwen Code provider#248
brenorb wants to merge 1 commit intosteipete:mainfrom
brenorb:upstream-pr/qwen-code

Conversation

@brenorb
Copy link

@brenorb brenorb commented Jan 26, 2026

Summary

  • Add Qwen Code provider (JSONL usage parsing, settings, registration).
  • Integrate across core/app/widget; add icon + docs.
  • Add tests for JSONL usage aggregation.

Verification

  • macOS: Qwen Code shows up in Providers and works locally.
  • Vibe-coded from Codex.

Testing

  • swiftformat Sources Tests
  • swiftlint --strict
  • pnpm check
  • ./Scripts/compile_and_run.sh

Closes #247

@brenorb brenorb force-pushed the upstream-pr/qwen-code branch from 3d1f1be to 66bf184 Compare January 26, 2026 01:45
@brenorb
Copy link
Author

brenorb commented Jan 26, 2026

It's my first big contribution and also first 100% vibecoded with Codex (from what I learned with you so far). I hope it looks good to you.

Copy link
Collaborator

@ratulsarna ratulsarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding Qwen support - the local log parsing itself looks reasonable.

Requesting changes for one core correctness issue: we currently present Qwen as if quota/reset semantics are authoritative ("% left" + "Resets in ..."), but we do not have provider-confirmed window/reset metadata for Qwen OAuth free tier. Public docs expose quota amounts, but not reset timezone/window semantics.

That means current behavior can be materially wrong (both reset countdown and percent-left math), depending on backend window definition.

Please adjust this PR to avoid false precision:

  1. Remove/hide "Resets in ..." for Qwen, or explicitly mark it as unknown.
  2. Remove/hide quota percent-left for Qwen (or clearly label as estimate).
  3. Add an explicit docs/UI note that Qwen values are inferred from local logs and may not match backend quota windows.

Once representation is honest about uncertainty, I'm comfortable with keeping Qwen provider support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot find Qwen in Providers list

2 participants

Comments