chore(deps): bump the prod-dependencies group with 3 updates - #2073
Conversation
Bumps the prod-dependencies group with 3 updates: [fastify](https://github.com/fastify/fastify), [i18next](https://github.com/i18next/i18next) and [react-i18next](https://github.com/i18next/react-i18next). Updates `fastify` from 5.12.1 to 5.12.3 - [Release notes](https://github.com/fastify/fastify/releases) - [Commits](https://github.com/fastify/fastify/commits) Updates `i18next` from 26.4.0 to 26.4.2 - [Release notes](https://github.com/i18next/i18next/releases) - [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md) - [Commits](i18next/i18next@v26.4.0...v26.4.2) Updates `react-i18next` from 17.0.12 to 17.0.13 - [Changelog](https://github.com/i18next/react-i18next/blob/master/CHANGELOG.md) - [Commits](i18next/react-i18next@v17.0.12...v17.0.13) --- updated-dependencies: - dependency-name: fastify dependency-version: 5.12.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: prod-dependencies - dependency-name: i18next dependency-version: 26.4.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: prod-dependencies - dependency-name: react-i18next dependency-version: 17.0.13 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: prod-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
SearchPicker and HouseholdItemPicker tests drove userEvent.type() under real timers against a 300ms search debounce, so each keystroke burned wall-clock time and waitFor polled in real time, drifting past the 60s per-test limit under CI load. Convert them to the fake-timer pattern already used by the passing debounce tests in the same file and restore real timers in afterEach. No assertions changed. Co-Authored-By: Claude qa-integration-tester <noreply@anthropic.com> Co-Authored-By: Claude dev-team-lead <noreply@anthropic.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Converting individual tests was not enough: the file spends ~357s across its passing tests under real timers, so any of them can drift past the 60s limit. Hoist jest.useFakeTimers() and a shared userEvent instance into the describe-level beforeEach, after the dynamic import, and drop the redundant per-test setup calls. No assertions changed. Co-Authored-By: Claude qa-integration-tester <noreply@anthropic.com> Co-Authored-By: Claude dev-team-lead <noreply@anthropic.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The untreated baseline showed SearchPicker.test.tsx taking 2377s with 10 tests exceeding the 60s limit; converting two of them was not enough. Hoist jest.useFakeTimers() and a shared userEvent instance into each of the five describe blocks' beforeEach, add the missing useRealTimers cleanup to the Floating UI block, and advance past the 300ms debounce after every type/clear. No assertions changed. Co-Authored-By: Claude qa-integration-tester <noreply@anthropic.com> Co-Authored-By: Claude dev-team-lead <noreply@anthropic.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
steilerDev
left a comment
There was a problem hiding this comment.
Security review
CLEAR — Tier 2 review (runtime dependencies with linked advisories), performed by security-engineer.
Alert closure. The four linked open alerts (#113/#114 GHSA-w2qp-rph6-63g4, #108/#109 GHSA-3m5p-2c4r-xxw2) both list first_patched_version: 5.12.1, which beta already carries — they show as open only because Dependabot scores against main, still on fastify@5.11.0. This PR does not close them; a prior beta PR already did. GHSA-3m5p-2c4r-xxw2 is additionally moot here: TRUST_PROXY is parsed boolean-only (server/src/plugins/config.ts:146-151, app.ts:75), never the vulnerable numeric hop-count form.
Not in the alert feed but genuinely fixed by this bump — fastify 5.12.2 was a security release for four HIGH-severity advisories not yet synced to the public Advisory API. Each was checked against this codebase and none is currently exploitable: GHSA-9q9j-q6p8-xq58 (no headers: schema uses a dependencies keyword), GHSA-hwr6-493r-vm6h (no schema set to boolean false), GHSA-p68q-wchp-6fh7 (single non-prefixed setNotFoundHandler on the root instance), GHSA-667r-xxjv-c9mm (no $async schema usage). Upgrading closes the class defensively.
Lockfile. No new or changed transitives beyond the three named packages; find-my-way and all @fastify/* versions unchanged. fast-uri already resolves to patched 3.1.7 / 4.1.3.
Changelog review
- Breaking: none.
- Bugfix-relevant: fastify 5.12.2's four advisory fixes (above); i18next 26.4.2's
nest()$-escape fix. - Adoption opportunities: none.
- Neutral: i18next 26.4.1
getFixedT()selector typing (we don't useenableSelector: 'strict'); react-i18next 17.0.13 is a types-only release — the tarball diff versus 17.0.12 shows zero runtime.jschanges.
CI note — the test failures were not caused by this bump
This PR was red on Jest shards 5/6 with 60s timeouts. Investigation showed the bump is not responsible:
- PR #2072 — which contains no i18next/react-i18next/fastify change at all — fails the identical tests.
- The regression entered
betain038a9431(PR #2070:@testing-library/user-event14.6.1→14.6.7,jest30.4.2→30.5.1), which masked it by raisingtestTimeoutto 60000. SearchPicker.test.tsxalready took 1466s while passing on #2070; it is inherently a 24-40 minute file, so runner variance alone decides which tests cross the ceiling. The failing set differed on every run (10 → 2 → 3, different tests each time).
Three commits on this branch harden the affected suites onto fake timers (81666cd3, 072f4f88, a9f8acad), taking shard 6 from 4 failures to green and shard 5 from 10 failures to 3. No assertion was weakened and testTimeout was not raised. The residual repo-wide exposure — 587 bare userEvent.setup() calls across client tests — is tracked in #2078.
Approved by the /dependabot skill.
|
🎉 This PR is included in version 2.15.0-beta.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Bumps the prod-dependencies group with 3 updates: fastify, i18next and react-i18next.
Updates
fastifyfrom 5.12.1 to 5.12.3Release notes
Sourced from fastify's releases.
Commits
Updates
i18nextfrom 26.4.0 to 26.4.2Release notes
Sourced from i18next's releases.
Changelog
Sourced from i18next's changelog.
Commits
4dba50f26.4.2e436b62buildd955fb0fix: stringify formatter results in nested values, changelog v26.4.2dfafa3cfix: keep replacement patterns literal in nested values (#2447)3c9981echore: keep dev-only and local files out of the npm packagec057ee026.4.102e3e16changelog v26.4.16f198f2fix(types): allow selector keyPrefix in getFixedT under enableSelector 'stric...Updates
react-i18nextfrom 17.0.12 to 17.0.13Changelog
Sourced from react-i18next's changelog.
Commits
addf64617.0.137c634eechangelog v17.0.135ceefb0fix(types): allow selector keyPrefix in useTranslation under enableSelector '...aa7ba52chore(examples): require activesupport >= 7.2.3.1 in the RN Gemfilesec0bb4echore(examples): drop react_native_windows and the RN Gemfile.locksaa5fc43buildDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions