refactor: use shared extheartbeat instead of local heartbeat package#54
Merged
Conversation
Switch preflight_kit_sdk to extension-kit's extheartbeat watchdog (v1.10.7) and delete the local heartbeat package — it was a byte-identical copy of action-kit's, so sharing one implementation stops it diverging again. The re-Start monitor leak fix from #52 is preserved (Swap-and-Stop). No API impact: the local heartbeat package was SDK-internal.
|
Claude finished @joshiste's task in 2m 54s —— View job Claude's Task List
ReviewThis is a clean, mechanical refactor — no functional/behavioral concerns.
No bugs, security issues, or concurrency issues found in the diff itself. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Switches
preflight_kit_sdkto the sharedextheartbeatwatchdog from extension-kit (extension-kit#150, released v1.10.7) and deletes the localpreflight_kit_sdk/v2/heartbeatpackage.It was a byte-identical copy of action-kit's heartbeat monitor — the same concurrency bug had to be fixed in both (preflight-kit#52, action-kit#457). Sharing one implementation stops it diverging again. extension-kit was already a dependency, so no new module coupling. Companion to action-kit#458.
The re-Start monitor-leak fix from #52 (Swap-and-Stop the previous monitor) is preserved.
API impact
None. The local
heartbeatpackage was SDK-internal (imported only bypreflight_sdk.go, not by extensions). Clean removal, agreed.Verification
heartbeatpackage removed.go build ./...,go vet ./...,go test -race ./...pass (modulego/preflight_kit_sdk); existing stop/heartbeat/leak tests still pass.