Repository navigation
Conversation
Replace the computed relative tolerance comparison with an `@stdlib/number/float16/base/assert/is-almost-same-value` check using the minimum required ULP bound of `0`. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UKvuHN7ztwJb2egVTPev2z
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
constants/float16/ln-twofrom a relative tolerance assertion to a ULP difference assertion.The
export equals lnf(2)test previously computeddelta = absf( float64ToFloat16( v - FLOAT16_LN2 ) )andtol = EPS * FLOAT16_LN2and asserted witht.ok( delta <= tol, ... ). It now delegates to@stdlib/number/float16/base/assert/is-almost-same-value:Final ULP constant:
0.test/test.jsNotes on how the bound was measured:
64,8,1, and0, and passes at every step, so0is the measured minimum and no smaller bound exists.ulpDifference( v, FLOAT16_LN2 )is exactly0: the computed valuefloat64ToFloat16( lnf( 2.0 ) )and the exported constant are both0.693359375, i.e., bit-identical in half-precision.maxULP === 0short-circuits toisSameValue, so the final assertion is an exact (same-value) comparison. This matches the already-mergedconstants/float16/ln-half(test: migrateconstants/float16/ln-halfto ULP-based assertions #16173) andconstants/float16/pi-squared(test: migrateconstants/float16/pi-squaredto ULP-based assertions #16170) conversions, which likewise settled on0.constants/float16/*packages (ln-half,ln-ten,half-ln-two,pi-squared). Accordingly, the computed value is rounded to half-precision viafloat64ToFloat16before comparison, mirroring those packages (the previous code instead rounded the difference).4assertions pass both times.test.native.js, so there is no JS/C divergence to account for.typeofand the exactfloat64ToFloat16( 0.6931471805599453 )value check) are intentionally left unchanged, as exact comparisons remain correct there.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The structure of the change intentionally mirrors the already-merged
constants/float16/ln-halfconversion (#16173), which has a near-identical test file in the same family.The bound is reproducible across architectures: the comparison is between two compile-time-fixed half-precision values and is not subject to FMA-contraction differences.
Note that the local
makepre-commit EditorConfig check could not run in this environment (theeditorconfig-checkerbinary download is network-blocked), so the changed file was verified manually for tabs-only indentation, no trailing whitespace on changed lines, LF endings, and a final newline. The JavaScript test lint (make lint-javascript-tests) and the filename lint ran and passed, as didmake testfor this package.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code. It studied the already-converted packages in the same family (notably
constants/float16/ln-halfandconstants/float16/pi-squared) to match the established idiom, then measured the minimum ULP bound empirically and verified determinism as described above.@stdlib-js/reviewers
Generated by Claude Code