test: migrate simulate/iter/sawtooth-wave to ULP-based assertions - #15109
Draft
kgryte wants to merge 1 commit into
Draft
test: migrate simulate/iter/sawtooth-wave to ULP-based assertions#15109kgryte wants to merge 1 commit into
simulate/iter/sawtooth-wave to ULP-based assertions#15109kgryte wants to merge 1 commit into
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WqqdPYJ7b95CKX13XpdtDH
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
simulate/iter/sawtooth-wavefrom relative tolerance testing to ULP difference testing, as described in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolcomparison blocks intest/test.jswitht.strictEqual( isAlmostSameValue( actual.value, expected[ i ].value, N ), true, 'returns expected value' );, adds the@stdlib/assert/is-almost-same-valueimport, and removes the now unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsimports.ULP bounds used, tightened to the measured minimum for each test case:
00000001All values except one are bit-for-bit exact, and thus use a bound of
0ULP. Theitertest case requires1ULP, as the returned value-0.5000000000000001differs from the expected literal-0.5by exactly one ULP; lowering that bound to0causes the assertion to fail, confirming1is the minimum. The suite (240 assertions) was run twice at the final bounds with identical results.The package has no
test/test.native.js, so no native test file required updating.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only
lib/node_modules/@stdlib/simulate/iter/sawtooth-wave/test/test.jsis modified.make test TESTS_FILTER=".*/simulate/iter/sawtooth-wave/.*"passes (240/240), and ESLint reports no problems for the modified file.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated, unattended migration task. The ULP bounds were measured empirically by running the test suite rather than estimated.
@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01WqqdPYJ7b95CKX13XpdtDH
Generated by Claude Code