style: remove unnecessary Boolean wrapper in number/float32/base/assert/is-almost-same-value - #15105
Draft
Planeshifter wants to merge 1 commit into
Draft
style: remove unnecessary Boolean wrapper in number/float32/base/assert/is-almost-same-value#15105Planeshifter wants to merge 1 commit into
Boolean wrapper in number/float32/base/assert/is-almost-same-value#15105Planeshifter wants to merge 1 commit into
Conversation
…ssert/is-almost-same-value` Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cqui9ZeHrFTj5SaDNvZHet
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetweenb74c2687(2026-09-07T14:54:49-07:00) and02db01b3(2026-09-07T23:32:32-07:00).Fixes by package:
number/float32/base/assert/is-almost-same-valuelib/node_modules/@stdlib/number/float32/base/assert/is-almost-same-value/lib/native.js(f2e4c4f), the addon result is wrapped inBoolean( addon( a, b, maxULP ) )and@stdlib/boolean/ctoris imported for it, but the addon already usesSTDLIB_NAPI_CREATE_BOOLEAN, which returns a real JS boolean vianapi_get_boolean. Drop the import and returnaddon( a, b, maxULP )directly, matching every otherSTDLIB_NAPI_CREATE_BOOLEANwrapper in the codebase and the float64 companion (02db01b).Related Issues
No.
Questions
No.
Other
Validation performed on the reviewed commit window (14 commits, 58 files):
docs/style-guidesand established reference packages (number/float64/base/assert/is-same-value,blas/ext/base/dany); repo-wide survey confirmed 9 of 9 otherSTDLIB_NAPI_CREATE_BOOLEAN-based addon wrappers return the addon result unwrapped.test.native.jsfiles, which cannot be validated without building the native add-ons and whose ULP values were empirically confirmed against fixtures on the JS implementations.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated review of commits recently merged to
develop; findings were cross-validated by multiple independent review passes before inclusion.🤖 Generated with Claude Code
https://claude.ai/code/session_01Cqui9ZeHrFTj5SaDNvZHet
Generated by Claude Code