feat: add C implementation for stats/base/ndarray/snanmskmin - #15103
feat: add C implementation for stats/base/ndarray/snanmskmin#15103himayurjogade wants to merge 1 commit into
stats/base/ndarray/snanmskmin#15103Conversation
Ref: stdlib-js#14034 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
Statistics
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
stdlib-bot
added
Needs Review
2 participants
Part of #14034.
Description
This pull request:
@stdlib/stats/base/ndarray/snanmskmin.tryRequiredispatcher with a fallback to theJavaScript implementation when the native addon is unavailable.
Related Issues
This pull request has the following related issues:
@stdlib/stats/base/ndarraypackages (tracking issue) #14034Questions
No.
Other
stats/base/ndarray/dmskmax,which has the same two-ndarray (input + mask) signature.
All changes were reviewed and verified locally. The native addon compiles without warnings, all 18 native test assertions pass with results matching the existing JavaScript implementation, the C example and benchmarks run correctly, and ESLint reports no errors.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
AI assistance was used for research and understanding of the codebase. All changes were reviewed and verified locally. The native addon compiles without warnings, all 18 native test assertions pass with results matching the existing JavaScript implementation, the C example and benchmarks run correctly, and ESLint reports no errors.
@stdlib-js/reviewers