fix: propagate recent develop fixes to sibling packages#12814
Draft
Planeshifter wants to merge 2 commits into
Draft
fix: propagate recent develop fixes to sibling packages#12814Planeshifter wants to merge 2 commits into
Planeshifter wants to merge 2 commits into
Conversation
Propagates fix from f1e2034 ("fix: type `dtype` parameter as `DataType`") to `assert/is-ndarray-like-with-data-type` and `ndarray/base/dtype-alignment`, whose declarations typed the ndarray data type parameter as `any`.
Propagates fix from 9630dd7 ("docs: order `float16` before `float32` in data type lists") to seven sibling packages under `utils/` whose README and REPL data type lists placed `float16` after `float32` and `float64`.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween692e1d78(2026-06-09 10:07 -0700) and95792b76(2026-06-10 01:13 -0700) to sibling packages with the same underlying defect.Pattern: type
dtypeparameter asDataTypeSource commit
f1e20349narrowed thedtypeparameter ofblas/tools/swap-factoryfromanytoDataType(imported from@stdlib/types/ndarray). The samedtype: anydefect persists in two sibling declarations whose runtime accepts onlyDataType-typed inputs as exercised by the existing JSDoc examples and type tests. Five additionaldtype: anysites were inspected and excluded: their runtime accepts numeric enums, struct constructors, or other inputs thatDataTypewould not cover.f1e20349(fix: type \dtype` parameter as `DataType``)@stdlib/assert/is-ndarray-like-with-data-type@stdlib/ndarray/base/dtype-alignmentPattern: order
float16beforefloat32in data type listsSource commit
9630dd78reordered the data type bullet lists inarray/ctorsandarray/typed-ctorsso thatfloat16precedesfloat32andfloat64. The identical out-of-order block (float64,float32,float16) appears in the README anddocs/repl.txtof seven siblingutils/*packages whose floating-point sub-lists are contiguous and have no interleaved integer bullets.9630dd78(docs: order \float16` before `float32` in data type lists`)@stdlib/utils/type-min@stdlib/utils/type-max@stdlib/utils/size-of@stdlib/utils/safe-int-min@stdlib/utils/safe-int-max@stdlib/utils/real-min@stdlib/utils/real-maxRelated Issues
None.
Questions
No.
Other
Validation
lib/node_modules/@stdlib/**/docs/types/index.d.tsfiles for thedtype:\s*anysignature; Pattern B scoped to alllib/node_modules/@stdlib/**/{README.md,docs/repl.txt}files for the three-bullet float ordering signature.confirmedadvanced. For Pattern B, all 14 candidate files were independently confirmed./// <reference types="@stdlib/types"/>directive and the named-import line mirror the source commit's placement after the// TypeScript Version:comment; for Pattern B, README bullets use- \floatXX`: description(no trailing period) andrepl.txtbullets use- floatXX: description.` (trailing period), preserved exactly.Deliberately excluded:
ndarray/base/buffer-ctors,bytes-per-element,dtype-char,dtype2c,dtype-desc: the runtime accepts inputs beyondDataType— struct constructors (Function), numeric dtype enum constants viadtype-resolve-str, or arbitrary objects with abyteLengthproperty — so narrowing the declaration would not match the implementation. Logged in the local report for a future routine that can adapt the fix (DataType | numberorDataType | Function).ndarray/base/dtype-resolve-{str,enum}andstrided/base/dtype-resolve-{str,enum}: same shape but require the broaderDataType | numbertyping (and the strided sibling needs the stridedDataType, not the ndarray one) — both fall outside the source commit's mechanical pattern.random/streams/randnmissing-prng-option fix, therandom/array/*assign-example fix, the missing-closing-brace TypeScript test fix, and the rayleigh-ctorskewness-arity fix: each pattern's signature search returned zero remaining sites across the namespace.iterdeclarations, thenlp/ldawhitespace fix, thedcorrelationparameter-type widening, thendarray/withgeneric binding, thetime/quarter-of-yearnotes addition, and the workflow shell-injection hardening.chore: fix JavaScript lint errors: the two-package source touches aSymbol.toStringTaglint suppression (one-off, requires per-site judgment) and a bracket-spacing style fornew Float64Array([...])calls — bracket style is contextual rather than a defect.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code on behalf of @Planeshifter as an automated propagation of fixes merged to
developover the prior 24 hours. Candidate source commits were filtered for generalisable patterns, sibling sites located via grep-able pattern signatures, and each proposed patch independently validated by parallel reviewer agents (two opus validation passes plus a sonnet style-consistency pass) before commits were applied in the primary worktree. A human will audit and promote the PR out of draft.@stdlib-js/reviewers
Generated by Claude Code