Skip to content

chore: follow-up fixes for develop (2026-06-09 → 2026-06-10)#12813

Draft
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-06-10
Draft

chore: follow-up fixes for develop (2026-06-09 → 2026-06-10)#12813
Planeshifter wants to merge 2 commits into
developfrom
philipp/fix-commit-review-2026-06-10

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Jun 10, 2026

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • Follow-up fixes for commits merged to develop between 2026-06-09 10:07 -0700 and 2026-06-10 01:13 -0700 (27 commits reviewed).

Fixes by package:

stats/incr/nanmsumabs (from 50463ad3)

  • Fix broken TSDoc @example in stats/incr/nanmsumabs/docs/types/index.d.ts where require bound to nanmsumabs but the example then called undeclared incrnanmsumabs; drop the stray require line to match siblings nanmse and nanrmse. [50463ad3]
  • Fix single blank line between import and // TESTS // comment in stats/incr/nanmsumabs/docs/types/test.ts; two blank lines are required per convention (cf. mse, rmse, msumabs, nanmse, nanrmse). [50463ad3]

stats/incr/nanmse (from 692e1d78)

  • Correct <img src> in stats/incr/nanmse/README.md: replaced CDN URL pointing to the incr/mse source-package SVG with local path ./docs/img/equation_mean_squared_error.svg (sibling new packages nanrmse and nanmsumabs already use the local path). [692e1d78]

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation audit. Each fix was cross-confirmed against sibling packages in the same namespace before applying. Edits were limited to the diff window of the originating commit; no surrounding code was reformatted.

Audit covered:

  • stdlib JS style-guide compliance against established sibling packages
  • Diff-only bug scan and a separate logic/security scan over the union diff

Deliberately excluded:

  • Workflow ${{ ... }} interpolations remaining in run: shells of 57a83de40a. Each remaining interpolation is bound to a GitHub-validated input type (boolean, choice, or number), so no shell-injection risk remains; the hardening commit correctly targeted only free-form string inputs.
  • Pre-existing subd2ind import alias typo in ndarray/sub2ind/docs/types/test.ts. Outside the diff window of 098451fcfd.
  • Stylistic randu()-0.5 operator spacing in new accumulator benchmarks. Matches the existing stats/incr benchmark convention across mse, rmse, msumabs, etc.
  • Wording of the "Notes" section in time/quarter-of-year. Borderline interpretation; not a clear-cut error.

Dropped during CI follow-up:

  • Originally included a third fix realigning the Complex128 ndarray REPL output in blas/ext/base/ndarray/zaxpby/docs/repl.txt to use decimal notation and a space after the comma (<Complex128>[ 3.0, 4.0 ]) — consistent with the package's own README and JSDoc and with all sibling Complex128 REPL examples. The decimal form pushed the output line to 94 characters, violating the REPL line-length rule (80-char cap). Reverting was preferred to expanding scope into the input ndarray data on adjacent lines; the cosmetic mismatch with the README remains for a maintainer to decide.

A local report with the full validated-issue list, dropped findings, and originating commit window lives at ~/drift-reports/commit-review-2026-06-10.md.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance.

This PR was authored by Claude Code running an automated commit-review routine over develop. The routine summarized the 24-hour commit window, fanned out parallel reviewer subagents (style compliance against reference packages, diff-only bug scan, logic/security scan), de-duplicated and verified findings against sibling packages, and applied only the high-signal fixes listed above. Each fix was re-read post-edit; PR-body bullets were drafted by per-issue refinement subagents.


@stdlib-js/reviewers

claude added 2 commits June 10, 2026 12:28
…msumabs`

Drop the stray `var nanmsumabs = require( ... );` line from the TSDoc
@example block (which then called the undeclared `incrnanmsumabs`) and
add the missing second blank line before `// TESTS //` in the TS test
file to match sibling packages.
Sibling new packages `nanrmse` and `nanmsumabs` use a local
`./docs/img/...` path for the HTML-fallback equation image; `nanmse`
ships its own SVG but pointed at the source package's CDN URL.
@stdlib-bot

stdlib-bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmse $\\color{green}129/129$
$\\color{green}+100.00\\%$
$\\color{green}8/8$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}129/129$
$\\color{green}+100.00\\%$
stats/incr/nanmsumabs $\\color{green}142/142$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}142/142$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter force-pushed the philipp/fix-commit-review-2026-06-10 branch from 1a74ffc to 73875e8 Compare June 10, 2026 12:35
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants