chore: follow-up fixes for develop (2026-06-09 → 2026-06-10)#12813
Draft
Planeshifter wants to merge 2 commits into
Draft
chore: follow-up fixes for develop (2026-06-09 → 2026-06-10)#12813Planeshifter wants to merge 2 commits into
Planeshifter wants to merge 2 commits into
Conversation
…msumabs` Drop the stray `var nanmsumabs = require( ... );` line from the TSDoc @example block (which then called the undeclared `incrnanmsumabs`) and add the missing second blank line before `// TESTS //` in the TS test file to match sibling packages.
Sibling new packages `nanrmse` and `nanmsumabs` use a local `./docs/img/...` path for the HTML-fallback equation image; `nanmse` ships its own SVG but pointed at the source package's CDN URL.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
1a74ffc to
73875e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetween2026-06-09 10:07 -0700and2026-06-10 01:13 -0700(27 commits reviewed).Fixes by package:
stats/incr/nanmsumabs(from50463ad3)@exampleinstats/incr/nanmsumabs/docs/types/index.d.tswhererequirebound tonanmsumabsbut the example then called undeclaredincrnanmsumabs; drop the strayrequireline to match siblingsnanmseandnanrmse. [50463ad3]// TESTS //comment instats/incr/nanmsumabs/docs/types/test.ts; two blank lines are required per convention (cf.mse,rmse,msumabs,nanmse,nanrmse). [50463ad3]stats/incr/nanmse(from692e1d78)<img src>instats/incr/nanmse/README.md: replaced CDN URL pointing to theincr/msesource-package SVG with local path./docs/img/equation_mean_squared_error.svg(sibling new packagesnanrmseandnanmsumabsalready use the local path). [692e1d78]Related Issues
None.
Questions
No.
Other
Validation audit. Each fix was cross-confirmed against sibling packages in the same namespace before applying. Edits were limited to the diff window of the originating commit; no surrounding code was reformatted.
Audit covered:
Deliberately excluded:
${{ ... }}interpolations remaining inrun:shells of57a83de40a. Each remaining interpolation is bound to a GitHub-validated input type (boolean,choice, ornumber), so no shell-injection risk remains; the hardening commit correctly targeted only free-form string inputs.subd2indimport alias typo inndarray/sub2ind/docs/types/test.ts. Outside the diff window of098451fcfd.randu()-0.5operator spacing in new accumulator benchmarks. Matches the existing stats/incr benchmark convention acrossmse,rmse,msumabs, etc.time/quarter-of-year. Borderline interpretation; not a clear-cut error.Dropped during CI follow-up:
blas/ext/base/ndarray/zaxpby/docs/repl.txtto use decimal notation and a space after the comma (<Complex128>[ 3.0, 4.0 ]) — consistent with the package's own README and JSDoc and with all sibling Complex128 REPL examples. The decimal form pushed the output line to 94 characters, violating the REPLline-lengthrule (80-char cap). Reverting was preferred to expanding scope into the input ndarray data on adjacent lines; the cosmetic mismatch with the README remains for a maintainer to decide.A local report with the full validated-issue list, dropped findings, and originating commit window lives at
~/drift-reports/commit-review-2026-06-10.md.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running an automated commit-review routine over
develop. The routine summarized the 24-hour commit window, fanned out parallel reviewer subagents (style compliance against reference packages, diff-only bug scan, logic/security scan), de-duplicated and verified findings against sibling packages, and applied only the high-signal fixes listed above. Each fix was re-read post-edit; PR-body bullets were drafted by per-issue refinement subagents.@stdlib-js/reviewers