Skip to content

feat!: migrate stats/strided/dmaxabssorted to stats/strided/dmaxabs-sorted#12812

Open
Neerajpathak07 wants to merge 4 commits into
stdlib-js:developfrom
Neerajpathak07:feat/migrate-dmaxabssorted
Open

feat!: migrate stats/strided/dmaxabssorted to stats/strided/dmaxabs-sorted#12812
Neerajpathak07 wants to merge 4 commits into
stdlib-js:developfrom
Neerajpathak07:feat/migrate-dmaxabssorted

Conversation

@Neerajpathak07

Copy link
Copy Markdown
Member

Progressess #12697.

Description

What is the purpose of this pull request?

This pull request:

  • Migrates stats/strided/dmaxabssorted to stats/strided/dmaxabs-sorted

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

This commit renames the `dmaxabssorted` symbol to `dmaxabsSorted` due to a package migration.

BREAKING CHANGE: rename `dmaxabssorted` to `dmaxabsSorted`

To migrate, users should update to the new symbol name.

Ref: stdlib-js#12697
This commit removes `@stdlib/stats/strided/dmaxabssorted` in favor of
`@stdlib/stats/strided/dmaxabs-sorted`.

BREAKING CHANGE: remove `stats/strided/dmaxabssorted`

To migrate, users should update their require/import paths to use
`@stdlib/stats/strided/dmaxabs-sorted` which provides the same API and implementation.

Ref: stdlib-js#12697
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
namespace/alias2pkg $\\color{green}95/95$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}95/95$
$\\color{green}+100.00\\%$
namespace/alias2related $\\color{green}95/95$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}95/95$
$\\color{green}+100.00\\%$
namespace/alias2standalone $\\color{green}95/95$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}95/95$
$\\color{green}+100.00\\%$
namespace/aliases $\\color{green}144/144$
$\\color{green}+100.00\\%$
$\\color{green}14/14$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}144/144$
$\\color{green}+100.00\\%$
namespace $\\color{red}40129/40232$
$\\color{green}+99.74\\%$
$\\color{green}113/113$
$\\color{green}+100.00\\%$
$\\color{red}2/11$
$\\color{green}+18.18\\%$
$\\color{red}40129/40232$
$\\color{green}+99.74\\%$
namespace/pkg2alias $\\color{green}100/100$
$\\color{green}+100.00\\%$
$\\color{green}10/10$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}100/100$
$\\color{green}+100.00\\%$
namespace/pkg2related $\\color{green}100/100$
$\\color{green}+100.00\\%$
$\\color{green}10/10$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}100/100$
$\\color{green}+100.00\\%$
namespace/pkg2standalone $\\color{green}95/95$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}95/95$
$\\color{green}+100.00\\%$
namespace/standalone2pkg $\\color{green}95/95$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}95/95$
$\\color{green}+100.00\\%$
stats/base/ndarray/dmaxabssorted $\\color{green}103/103$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}103/103$
$\\color{green}+100.00\\%$
stats/strided $\\color{red}68530/79426$
$\\color{green}+86.28\\%$
$\\color{red}1318/1483$
$\\color{green}+88.87\\%$
$\\color{red}0/713$
$\\color{green}+0.00\\%$
$\\color{red}68530/79426$
$\\color{green}+86.28\\%$
stats/strided/dmaxabs-sorted $\\color{green}316/316$
$\\color{green}+100.00\\%$
$\\color{green}20/20$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}316/316$
$\\color{green}+100.00\\%$
stats/strided $\\color{red}68530/79426$
$\\color{green}+86.28\\%$
$\\color{red}1318/1483$
$\\color{green}+88.87\\%$
$\\color{red}0/713$
$\\color{green}+0.00\\%$
$\\color{red}68530/79426$
$\\color{green}+86.28\\%$
stats/strided/smaxabssorted $\\color{green}316/316$
$\\color{green}+100.00\\%$
$\\color{green}20/20$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}316/316$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07

Copy link
Copy Markdown
Member Author

Since the benchmarks workflow is running for all the packages of stats/strided/* it is expected to terminate after 60 mins. As such I'll go ahead and open it for review!!

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review June 10, 2026 12:12
@Neerajpathak07 Neerajpathak07 requested a review from a team June 10, 2026 12:12
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 10, 2026
@Neerajpathak07 Neerajpathak07 added release: Major Breaking change requiring a new major release. and removed Needs Review A pull request which needs code review. labels Jun 10, 2026
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review. release: Major Breaking change requiring a new major release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants