Skip to content

test: migrate math/base/special/rempio2f to ULP-based testing#12810

Draft
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-rempio2f
Draft

test: migrate math/base/special/rempio2f to ULP-based testing#12810
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-rempio2f

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates test/test.js and test/test.native.js for math/base/special/rempio2f from relative-tolerance (EPS-based) assertions to ULP-difference assertions using @stdlib/number/float32/base/assert/is-almost-same-value (single-precision variant, following the convention used for other f packages such as acothf and atanhf), with the minimum required ULP values.
  • removes the now-unused absf and EPS requires and the delta/tol variables from migrated test blocks.

Details on the chosen ULP values:

  • This package has no fixtures; all five tolerance blocks are property-based round-trip checks comparing z = float64ToFloat32( (PIO2*n) + y[0] ) against the input x, with unseeded randu inputs in three of the blocks. Because the per-run ULP difference is not deterministic for random inputs, the bound was certified by exhaustive enumeration of all 1,120,403,456 single-precision values in (0, 100] for each sign: the maximum ULP difference is 1 in both directions, and roughly 0.35% of inputs in the domain produce a 1-ULP difference, so a 0 ULP tolerance would flake. 1 is therefore the minimum ULP value which never fails. The deterministic multiples-of-π/4 block likewise has a maximum ULP difference of 1 (2 of 20 cases are not exact).
  • The two "tiny" blocks degenerate: float64ToFloat32( ±1.0e-100 * randu() ) underflows to ±0, so the reconstruction is exact and the assertions use plain t.strictEqual( z, x, ... ) per the migration guidelines for exactly matching values.
  • The native (C) implementation was verified via a dense sweep (2e7 points per sign plus the π/4 set) to have the same maximum ULP difference of 1, with the tiny blocks exact, so the native ULP values are identical to the JavaScript values and no divergence note is required.

The minimum ULP values were independently re-verified by direct ULP-difference computation (exhaustive single-precision domain enumeration) prior to opening this pull request.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was written by Claude Code as part of an automated migration of test suites to ULP-based assertions (issue #11352). The minimum ULP values were computed programmatically and independently verified by a second adversarial agent before opening this PR.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Jun 10, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jun 10, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/rempio2f $\\color{red}632/645$
$\\color{green}+97.98\\%$
$\\color{red}45/50$
$\\color{green}+90.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{red}632/645$
$\\color{green}+97.98\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants