Skip to content

test: migrate math/base/special/hypotf to ULP-based testing#12808

Draft
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-hypotf
Draft

test: migrate math/base/special/hypotf to ULP-based testing#12808
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-hypotf

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates test/test.js and test/test.native.js of math/base/special/hypotf from relative-tolerance (EPS-based) assertions to ULP-difference assertions via @stdlib/number/float32/base/assert/is-almost-same-value, using the minimum required ULP values (verified by direct ULP-difference computation over the test fixtures: JS fixture block max 2 ULP, native fixture block max 2 ULP, native canonical-inputs block max 1 ULP).
  • as hypotf is single-precision, uses the float32 variant of is-almost-same-value and coerces fixture expected values via the file's existing float64ToFloat32 require, following the merged precedent in math/base/special/acothf (ed81430) and math/base/special/atanhf (7f68fc4); all 2003 fixture expected values are exactly representable in single precision, so the coercion is a semantic no-op.
  • preserves the native-vs-JS divergence handling for canonical inputs: the native implementation returns 12.999999046325684 (1 ULP below 13.0) for hypotf( 5.0, 12.0 ) due to compiler optimizations, while the JavaScript implementation is exact; the pre-existing NOTE comment (see 69e1068) is retained, the JavaScript test keeps a plain t.strictEqual, and the native assertion uses isAlmostSameValue( h, 13.0, 1 ).
  • removes the now-unused EPS and absf requires and delta/tol variables.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

All ULP values were independently recomputed (including the native results, via a locally built add-on) and confirmed to be the minimum integer values for which all test cases pass. Both the JavaScript and native test suites pass (2031 assertions each, native tests run against a real add-on build, no skips).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was written by Claude Code: the test migration was performed by an automated agent and independently verified by a second adversarial agent (which recomputed all minimum ULP values from the fixtures), with human supervision.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Jun 10, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jun 10, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/hypotf $\\color{green}185/185$
$\\color{green}+100.00\\%$
$\\color{green}19/19$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}185/185$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants