test: migrate math/base/special/cbrt to ULP-based testing#12806
Draft
Planeshifter wants to merge 1 commit into
Draft
test: migrate math/base/special/cbrt to ULP-based testing#12806Planeshifter wants to merge 1 commit into
math/base/special/cbrt to ULP-based testing#12806Planeshifter wants to merge 1 commit into
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
test/test.native.jsofmath/base/special/cbrtfrom relative-tolerance (EPS-based) assertions to exact equality assertions, completing the migration to ULP-based testing for this package.test/test.jswas already migrated in test: migratemath/base/special/cbrtto ULP-based testing #11839, which left the native test file behind.@stdlib/number/float64/base/ulp-difference) over all 14 Julia fixture files (7042 cases). The maximum ULP difference is0for every block, for both the JavaScript implementation and the native add-on, so plaint.strictEqual( y, expected[ i ], 'returns expected value' )is used rather thanisAlmostSameValue, per maintainer guidance to avoidisAlmostSameValuewhere values are exactly equal.EPSandabsrequires and thedelta/tolvariables, and collapses the obsolete exact-equality short-circuit branches.The native results did not diverge from the JavaScript implementation (verified locally on arm64/clang), so no compiler-optimization tolerance notes were needed. All 7049 native assertions pass locally with the add-on built and loaded.
Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352math/base/special/cbrtto ULP-based testing #11839Questions
No.
Other
The minimum ULP values were independently re-verified by a second pass which re-computed the maximum ULP difference per fixture block for both the JavaScript implementation and the compiled native add-on; all blocks are exactly
0ULP.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, including the test migration and the ULP-minimality computation; an independent automated verification pass (also Claude Code) re-computed the minimum ULP values and reviewed the diff before submission.
@stdlib-js/reviewers