test: migrate math/base/special/pow to ULP-based testing#12803
Draft
Planeshifter wants to merge 1 commit into
Draft
test: migrate math/base/special/pow to ULP-based testing#12803Planeshifter wants to merge 1 commit into
math/base/special/pow to ULP-based testing#12803Planeshifter wants to merge 1 commit into
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
test/test.native.jsformath/base/special/powfrom relative-tolerance (EPS-based) assertions to ULP-difference assertions via@stdlib/assert/is-almost-same-value, using the minimum required ULP values (verified by direct ULP-difference computation over the test fixtures).test/test.jsunchanged, as the JavaScript test file contains no relative-tolerance assertions: every fixture block already asserts exact equality viat.strictEqual, and a direct ULP-difference computation over all seven fixture sets confirms a maximum ULP difference of0for the JavaScript implementation.if ( actual === expected[i] ) { ... } else { ...tolerance... }) in the native test file into singleisAlmostSameValueassertions, asisAlmostSameValuecovers exact equality.1for all seven migrated native test blocks, which is larger than the JavaScript counterpart (exact,0ULP) due to compiler optimizations which may result in result divergence; accordingly, the canonicalNOTEcomment (see feat: add C implementation formath/base/special/spence#2298 and commit 69e1068) is added above each migrated assertion.5.0e-324(smallest subnormal) underflow branch in the smallx, largeytest block.EPSandabsrequires, as both are still used elsewhere in the native test file.ULP minimality was verified by confirming that a maximum ULP difference of
0produces native test failures, while1passes all assertions (73605+ assertions across all test files viamake test).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The native ULP values were measured on darwin arm64 (clang). CI should confirm the tolerances hold across other platforms and compilers.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, including the test migration and the minimum-ULP computation; an independent automated verification pass recomputed the ULP values against the fixtures before opening this PR.
@stdlib-js/reviewers