Skip to content

test: migrate math/base/special/ahaversinf to ULP-based testing#12798

Draft
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-ahaversinf
Draft

test: migrate math/base/special/ahaversinf to ULP-based testing#12798
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-ahaversinf

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates test/test.js and test/test.native.js in math/base/special/ahaversinf from relative-tolerance (EPS-based) assertions to ULP-difference assertions via @stdlib/number/float32/base/assert/is-almost-same-value (the single-precision variant, following the pattern established in math/base/special/acothf and math/base/special/atanhf), with expected values coerced to single precision via @stdlib/number/float64/base/to-float32.
  • uses the minimum required ULP values, verified by direct ULP-difference computation over the test fixtures using @stdlib/number/float32/base/ulp-difference:
    • data fixtures: maximum ULP difference of 2 (32 cases exceed ULP 1, so 2 is minimal).
    • small_positive fixtures: exact after single-precision coercion (maximum ULP difference of 0), so plain t.strictEqual( y, e, 'returns expected value' ) is used instead of isAlmostSameValue.
  • removes the now-unused @stdlib/math/base/special/absf require and the delta/tol variables; the @stdlib/constants/float32/eps require is retained, as it is still used by the out-of-domain (NaN) range tests.

Native (C) results are bit-identical to the JavaScript implementation on the test machine (arm64/clang): the same ULP values apply to both files, and no compiler-divergence NOTE annotation is needed. The native test suite was built and run successfully (all assertions passing), and the full JavaScript test harness passed as well.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The minimum ULP values were independently re-verified by an adversarial review pass which recomputed the maximum ULP difference per fixture block directly against the unchanged implementation.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was written by Claude Code as part of an automated migration of math/base/special test suites to ULP-based testing (issue #11352), including independent recomputation of the minimum ULP tolerances, and was reviewed by a separate adversarial verification pass before submission.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Good First PR A pull request resolving a Good First Issue. labels Jun 10, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/ahaversinf $\\color{green}170/170$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}170/170$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants