test: migrate math/base/special/deg2radf to ULP-based testing#12792
Draft
Planeshifter wants to merge 1 commit into
Draft
test: migrate math/base/special/deg2radf to ULP-based testing#12792Planeshifter wants to merge 1 commit into
math/base/special/deg2radf to ULP-based testing#12792Planeshifter wants to merge 1 commit into
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/deg2radffrom relative-tolerance (EPS-based) assertions to exact assertions, per the ULP-based testing migration tracked in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.test/test.js, direct ULP-difference computation (via@stdlib/number/float32/base/ulp-difference) over all 2003 fixture cases showed a maximum ULP difference of0(every fixture expected value is exactly single-precision representable, anddeg2radf( x )returns the expected value bit-for-bit). Accordingly, the exact-equality short-circuit and relative-tolerance branch collapse to a plaint.strictEqual( y, expected[ i ], 'returns expected value' );assertion, and the now-unusedEPSandabsfrequires anddelta/tolvariables are removed.test/test.native.jsunmodified, as it already uses exactstrictEqualassertions for the fixture block (no relative-tolerance assertions to migrate). The native add-on was built locally and all assertions pass with exact equality, confirming the JavaScript and C implementations agree bit-for-bit (no JS-vs-native divergence; no enlarged native tolerances needed).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The minimum ULP value (
0) was verified twice: once during migration and once by an independent adversarial verification pass which recomputed the maximum ULP difference over the test fixtures.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code as part of an automated migration of
math/base/specialtest suites to ULP-based testing (#11352), including minimum-ULP discovery and an independent adversarial verification pass; changes were reviewed by a human before submission.@stdlib-js/reviewers