test: migrate math/base/special/fmodf to ULP-based testing#12791
Draft
Planeshifter wants to merge 1 commit into
Draft
test: migrate math/base/special/fmodf to ULP-based testing#12791Planeshifter wants to merge 1 commit into
math/base/special/fmodf to ULP-based testing#12791Planeshifter wants to merge 1 commit into
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
test/test.jsandtest/test.native.jsof@stdlib/math/base/special/fmodffrom relative-tolerance (EPS-based) assertions to exact-equality assertions, per the migration guidelines in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.@stdlib/number/float32/base/ulp-difference, with single-precision coercion of inputs and expected values exactly as performed in the tests) over all 7 fixture blocks (20004 cases) measured a maximum ULP difference of0for every block. Asfmodis exact per IEEE 754, every assertion was therefore converted to a plaint.strictEqual( v, e, 'returns expected value' )rather thanisAlmostSameValue, following maintainer guidance thatisAlmostSameValueshould not be used where values are exactly equal.EPS(@stdlib/constants/float32/eps) andabsfrequires and thedelta/tolvariables.NOTEannotations were necessary.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code: an automated agent performed the test migration and computed the minimum required ULP values, and an independent adversarial verification agent recomputed the ULP values over all fixtures and reviewed the diff before opening this PR.
@stdlib-js/reviewers