feat: add C implementation for stats/base/dists/chi/skewness#10836
feat: add C implementation for stats/base/dists/chi/skewness#10836rautelaKamal wants to merge 6 commits intostdlib-js:developfrom
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Please do not open AI-generated PRs without double-checking what you are submitting and be transparent in disclosing usage of AI assistance. As you can see, the C implementation already exists, so this PR shouldn't have been opened. |
Thank you for the review and for catching this, @Planeshifter. I sincerely apologize for wasting your time. You are completely right on both counts. To be transparent: I have been using an AI assistant to help me learn the codebase structure and draft boilerplate for these implementations. In my eagerness to get a PR up, I became completely focused on getting the CI checks (linting, exports, tests) to pass for the new code I was generating. In doing so, I completely failed to do the most important step: checking the develop branch to see if the C implementation for chi/skewness was already there. The multiple commits were my sincere (but misguided) attempts to satisfy the CI, not an attempt to spam the repo. I take your feedback very seriously. Going forward, my protocol will be: I will manually verify against the latest develop branch that an implementation doesn't already exist before writing a single line of code. |
Description
This pull request:
@stdlib/stats/base/dists/chi/skewness.Checklist
AI Assistance
Other
No.
@stdlib-js/reviewers