Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15832.
That issue was only a symptom.
Since #15540, empty fields skip every modifier. That is great for the ones that choked on null, but it broke the ones where null is needed:
{{ if field | is_blank }}is false for empty fields 👀bool_stringneeded its own fix #15782. That fix is just a hardcoded list that grows with every bug report. Also addons can't use it, and the parameter syntax ignores it (and still throws on empty fields).This PR replaces the hard coded list with an AcceptsNull attribute on the modifier, marks bool_string, to_json and is_blank, and makes the parameter syntax skip null the same way.