[6.x] Fix false "Update available" when installed version is newer than marketplace version#14890
Open
aaronbushnell wants to merge 1 commit into
Open
[6.x] Fix false "Update available" when installed version is newer than marketplace version#14890aaronbushnell wants to merge 1 commit into
aaronbushnell wants to merge 1 commit into
Conversation
…ketplace latest The update check treated "not exactly equal to the marketplace's latest" as "an update is available", rather than "the installed version is older than the latest". This surfaced an "Update available" badge whenever a local install was ahead of the marketplace's indexed version (e.g. in the window between a release landing on Packagist and the marketplace indexing it). - Addon::isLatestVersion() now uses `>=` instead of strict equality, so an install equal to or newer than the marketplace latest is up to date. - The per-product updater badge derives "up to date" from the changelog's release types (no `upgrade` releases) instead of a string comparison, matching the server's classification and the count badge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CP shows a false "Update available" when the installed version is newer than the marketplace's indexed
latest_version. This happens routinely in the gap between a release hitting Packagist (installable via Composer) and statamic.com indexing it.Example:
statamic/seo-proinstalled at7.12.1, marketplacelatest_versionstill7.12.0→ amber "Update available" badge shown, and it's counted in the updates badge.What was altered:
Addon::isLatestVersion():'='→'>='. Equal-or-newer is up to date.Updater.vue: derive "up to date" from the changelog (no releases oftype === 'upgrade') instead of string equality. This reuses the server's existing release classification, so the per-product badge now agrees with the count badge.Related