[6.x] Fix grid header overlapping nav#14640
Merged
Merged
Conversation
Member
|
Thanks for giving this a go! We try not to use arbitrary z-index values but rather have vars to map out the various proper z-indexes in You up for taking a stab w/ those or should I take it from here? |
Contributor
Author
|
I fixed it already 👍 |
The grid fieldtype's sticky `thead th` was at `--z-index-draggable` (3), which matched the side nav and caused it to render over the mobile nav when sliding in. The table fieldtype uses `--z-index-above` (1) for the same kind of sticky header without issue, so bring grid in line and revert the nav-main z-index bump.
Member
|
Since Grid was the only fieldtype with an issue, I moved the fix to there, consistent with similar fieldtypes. This issue didn't happen for Replicator or Table fieldtypes (which also has a sticky header row). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix grid header overlaps navigation
Before:

After:

Fixes #14608