[6.x] Fix translator error with Symfony Console 8#14330
Merged
jasonvarga merged 2 commits into6.xfrom Mar 24, 2026
Merged
Conversation
jasonvarga
requested changes
Mar 24, 2026
Member
jasonvarga
left a comment
jasonvarga
left a comment
There was a problem hiding this comment.
This fixes the reported error but now when I run php translator translate fr for example, I get a different error:
Fatal error: Declaration of Statamic\Translator\Commands\Stats::configure() must be compatible with Symfony\Component\Console\Command\Command::configure(): void in /Users/jason/Code/statamic/cms/src/Translator/Commands/Stats.php on line 27
Member
Author
|
Whoops - should be sorted now. Sorry! 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the
translatorscript throws an error when running on Symfony Console 8.0.This was happening because Symfony Console 8.0 removed the
Application::add()method, which was deprecated in 7.4.This PR fixes it by using the replacement
Application::addCommand()method instead.Fixes #14324