Skip to content

Update Visage to v2.4.1 - #755

Merged
cc1234475 merged 1 commit into
stashapp:mainfrom
cc1234475:visage-v2.4.1
Aug 10, 2026
Merged

Update Visage to v2.4.1#755
cc1234475 merged 1 commit into
stashapp:mainfrom
cc1234475:visage-v2.4.1

Conversation

@cc1234475

Copy link
Copy Markdown
Collaborator

What's new in v2.4.1

Bug fix release for whole scene scanning.

Scene scan no longer fails with a play() AbortError

Some users saw Scene scan failed: The play() request was interrupted because the media was removed from the document. when a scene had no sprite sheet and the scan fell back to the preview video.

The frame extractor called play() on an off-screen video before seeking. That promise can be rejected for reasons outside the plugin's control, and the rejection killed the whole scan. Seeking a preload="auto" video already decodes and presents the frame, so playback was never needed. The call is gone.

Frame extraction hardening

  • Seek waits time out after 10s. Before, a stalled decode left the scan spinning forever with no way out except a page reload.
  • A stalled or failed seek now keeps the frames already captured and identifies on those, instead of failing the scan.
  • Previews reporting a non-finite duration are rejected with a clear message. ffmpeg previews can report Infinity, which produced NaN seek times.
  • The video element and both canvases are released in a finally block, so failed scans no longer leak the element and its buffered data.

Verified

Local Stash instance, Chrome: 12 distinct frames extracted in 235ms with zero play() calls, both the sprite and the preview scan paths complete end to end, and load failures surface a plain message with no unhandled rejections.

@cc1234475
cc1234475 merged commit c4d5011 into stashapp:main Aug 10, 2026
1 check passed
@DogmaDragon DogmaDragon added the type:plugin Plugins label Aug 11, 2026
@discourse-stashapp

Copy link
Copy Markdown

This pull request has been mentioned on Stash Forum. There might be relevant details there:

https://discourse.stashapp.cc/t/visage/11785/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants