Skip to content

Fix concurrent table schema lookups - #2641

Open
erichare wants to merge 1 commit into
mainfrom
fix/schema-cache-concurrent-lookups
Open

erichare wants to merge 1 commit into
mainfrom
fix/schema-cache-concurrent-lookups

Conversation

@erichare

@erichare erichare commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does:

Uses Caffeine's completed-value view for cache probes so concurrent table lookups reach the existing collection-to-table recovery instead of blocking and throwing. Adds a regression test for two requests sharing a pending schema load.

Validation: the regression fails before the fix. All 35 focused cache tests and formatting checks pass.

Which issue(s) this PR fixes:

Fixes #2640

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated (not needed)
  • CLA Signed: DataStax CLA

@erichare
erichare requested a review from a team as a code owner October 12, 2026 15:49
@github-actions

Copy link
Copy Markdown
Contributor

📉 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 54.71%
This PR 54.71%
Delta 🔴 -0.00%
⚠️ Coverage decreased

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Overall Project 54.71% 🍏
Files changed 100% 🍏

File Coverage
DynamicTTLCache.java 83.39% 🍏

@github-actions

Copy link
Copy Markdown
Contributor

📉 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 72.95%
This PR 72.95%
Delta 🔴 -0.00%
⚠️ Coverage decreased

@github-actions

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (dse69-it)

Overall Project 72.95% 🍏
Files changed 100% 🍏

File Coverage
DynamicTTLCache.java 71.38% 🍏

@github-actions

Copy link
Copy Markdown
Contributor

📉 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 74.27%
This PR 74.26%
Delta 🔴 -0.01%
⚠️ Coverage decreased

@github-actions

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (hcd-it)

Overall Project 74.26% 🍏
Files changed 100% 🍏

File Coverage
DynamicTTLCache.java 71.38% 🍏

@erichare
erichare requested a review from amorton October 12, 2026 18:09

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Concurrent table schema lookups can leak SchemaObjectTypeMismatchException

1 participant