You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
findAndRerank sends numbers and booleans in the rerankOn field to the reranker as text, e.g. 42 becomes "42" and 1.50 becomes "1.5". Objects and arrays fail the whole request with UNEXPECTED_SERVER_ERROR.
Only string values are now used as passages. Other types are excluded, the same as missing, null, and blank values, matching the docs.
Updates the ScoredDocument passage cases and adds an integration test that checks only the string passage reaches the reranker. The 44 reranking unit tests and FindAndRerankCollectionSuccessIntegrationTest pass on Java 21 against DSE.
Which issue(s) this PR fixes: Fixes#2613 Fixes#2611
@Hazel-Datastax this conflicts with the non-string rerankOn cases #2638 pins. I followed the docs (exclude them), but holding as draft until we agree which way to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
findAndReranksends numbers and booleans in thererankOnfield to the reranker as text, e.g.42becomes"42"and1.50becomes"1.5". Objects and arrays fail the whole request withUNEXPECTED_SERVER_ERROR.Only string values are now used as passages. Other types are excluded, the same as missing, null, and blank values, matching the docs.
Updates the
ScoredDocumentpassage cases and adds an integration test that checks only the string passage reaches the reranker. The 44 reranking unit tests andFindAndRerankCollectionSuccessIntegrationTestpass on Java 21 against DSE.Which issue(s) this PR fixes:
Fixes #2613
Fixes #2611
Checklist