Open
Conversation
Member
|
Thanks, so much, @Franzi2114. If nobody else can get to this, I can review it some time over the next week. |
Contributor
Author
|
Perfec,t thanks @bob-carpenter! I was also in contact with @WardBrian before I did the PR. There are still three open points that I didn't manage to incorporate:
Please let me know when there occur more points that I should change. |
Member
|
Hi @Franzi2114 -- I've just pushed a commit that addresses each of your comments, since they're mostly quarto-wrangling:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a user's guide entry for the wiener diffusion model. It is linked to the PRs for the seven parameter diffusion model PDF and CDF functions
stan-dev/math#2822
stan-dev/math#3042
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Franziska Henrich
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: